Skip to content

Commit 544f9a5

Browse files
xidedixxidedix
authored
Merge pull request #103 from coreui/fix-basic-forms
fix: basic forms
2 parents 6d7fe8f + 6407d87 commit 544f9a5

File tree

6 files changed

+80
-65
lines changed

6 files changed

+80
-65
lines changed

Diff for: ‎CHANGELOG.md

+11
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,16 @@
11
## [angular](./README.md) version `changelog`
22

3+
###### `v2.0.0-rc.4`
4+
- fix(forms): validation classes example closes #95
5+
- fix(forms): card-header-actions example
6+
- fix(forms): autocomplete
7+
- fix(login): form, autocomplete
8+
- fix(register): form, autocomplete
9+
- update: `@types/node` to `10.7.0`",`
10+
- update: `codelyzer` to `4.4.4`
11+
- update: `karma-jasmine-html-reporter` to `1.3.0`
12+
- update: `typescript` to `2.9.2`
13+
314
###### `v2.0.0-rc.3`
415
- fix(carousels): move to `loremflickr` image placeholders
516
- refactor: code cleanup

Diff for: ‎package.json

+5-5
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@coreui/coreui-free-angular-admin-template",
3-
"version": "2.0.0-rc.3",
3+
"version": "2.0.0-rc.4",
44
"description": "CoreUI Free Angular 2+ Admin Template",
55
"author": {
66
"name": "Łukasz Holeczek",
@@ -63,19 +63,19 @@
6363
"@angular/language-service": "^6.1.2",
6464
"@types/jasmine": "^2.8.8",
6565
"@types/jasminewd2": "^2.0.3",
66-
"@types/node": "^10.5.8",
67-
"codelyzer": "^4.4.3",
66+
"@types/node": "^10.7.0",
67+
"codelyzer": "^4.4.4",
6868
"jasmine-core": "^3.2.0",
6969
"jasmine-spec-reporter": "^4.2.1",
7070
"karma": "^3.0.0",
7171
"karma-chrome-launcher": "^2.2.0",
7272
"karma-coverage-istanbul-reporter": "^2.0.1",
7373
"karma-jasmine": "^1.1.2",
74-
"karma-jasmine-html-reporter": "^1.2.0",
74+
"karma-jasmine-html-reporter": "^1.3.0",
7575
"protractor": "5.4.0",
7676
"ts-node": "^7.0.1",
7777
"tslint": "^5.11.0",
78-
"typescript": "^2.7.2"
78+
"typescript": "^2.9.2"
7979
},
8080
"engines": {
8181
"node": ">= 8.9.4",

Diff for: ‎src/app/app.component.spec.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { RouterTestingModule } from '@angular/router/testing'
1+
import { RouterTestingModule } from '@angular/router/testing';
22
import { TestBed, async } from '@angular/core/testing';
33
import { AppComponent } from './app.component';
44
describe('AppComponent', () => {

Diff for: ‎src/app/views/base/forms.component.html

+17-17
Original file line numberDiff line numberDiff line change
@@ -129,14 +129,14 @@
129129
<div class="form-group row">
130130
<label class="col-md-3 col-form-label" for="email-input">Email Input</label>
131131
<div class="col-md-9">
132-
<input type="email" id="email-input" name="email-input" class="form-control" placeholder="Enter Email">
132+
<input type="email" id="email-input" name="email-input" class="form-control" placeholder="Enter Email" autocomplete="email">
133133
<span class="help-block">Please enter your email</span>
134134
</div>
135135
</div>
136136
<div class="form-group row">
137137
<label class="col-md-3 col-form-label" for="password-input">Password</label>
138138
<div class="col-md-9">
139-
<input type="password" id="password-input" name="password-input" class="form-control" placeholder="Password">
139+
<input type="password" id="password-input" name="password-input" class="form-control" placeholder="Password" autocomplete="current-password">
140140
<span class="help-block">Please enter a complex password</span>
141141
</div>
142142
</div>
@@ -320,11 +320,11 @@
320320
<form action="" method="post" class="form-inline">
321321
<div class="form-group">
322322
<label class="sr-only" for="if-email">Email</label>
323-
<input type="email" id="if-email" name="if-email" class="form-control" placeholder="Enter Email..">
323+
<input type="email" id="if-email" name="if-email" class="form-control" placeholder="Enter Email.." autocomplete="email">
324324
</div>
325325
<div class="form-group">
326326
<label class="sr-only" for="if-password">Password</label>
327-
<input type="password" id="if-password" name="if-password" class="form-control" placeholder="Enter Password..">
327+
<input type="password" id="if-password" name="if-password" class="form-control" placeholder="Enter Password.." autocomplete="current-password">
328328
</div>
329329
</form>
330330
</div>
@@ -344,14 +344,14 @@
344344
<div class="form-group row">
345345
<label class="col-md-3 col-form-label" for="hf-email">Email</label>
346346
<div class="col-md-9">
347-
<input type="email" id="hf-email" name="hf-email" class="form-control" placeholder="Enter Email..">
347+
<input type="email" id="hf-email" name="hf-email" class="form-control" placeholder="Enter Email.." autocomplete="email">
348348
<span class="help-block">Please enter your email</span>
349349
</div>
350350
</div>
351351
<div class="form-group row">
352352
<label class="col-md-3 col-form-label" for="hf-password">Password</label>
353353
<div class="col-md-9">
354-
<input type="password" id="hf-password" name="hf-password" class="form-control" placeholder="Enter Password..">
354+
<input type="password" id="hf-password" name="hf-password" class="form-control" placeholder="Enter Password.." autocomplete="current-password">
355355
<span class="help-block">Please enter your password</span>
356356
</div>
357357
</div>
@@ -370,12 +370,12 @@
370370
<form action="" method="post">
371371
<div class="form-group">
372372
<label for="nf-email">Email</label>
373-
<input type="email" id="nf-email" name="nf-email" class="form-control" placeholder="Enter Email..">
373+
<input type="email" id="nf-email" name="nf-email" class="form-control" placeholder="Enter Email.." autocomplete="email">
374374
<span class="help-block">Please enter your email</span>
375375
</div>
376376
<div class="form-group">
377377
<label for="nf-password">Password</label>
378-
<input type="password" id="nf-password" name="nf-password" class="form-control" placeholder="Enter Password..">
378+
<input type="password" id="nf-password" name="nf-password" class="form-control" placeholder="Enter Password.." autocomplete="current-password">
379379
<span class="help-block">Please enter your password</span>
380380
</div>
381381
</form>
@@ -559,7 +559,7 @@
559559
<div class="form-group row">
560560
<div class="col-md-12">
561561
<div class="input-group">
562-
<input type="email" id="input2-group1" name="input2-group1" class="form-control" placeholder="Email">
562+
<input type="email" id="input2-group1" name="input2-group1" class="form-control" placeholder="Email" autocomplete="email">
563563
<div class="input-group-append">
564564
<span class="input-group-text"><i class="fa fa-envelope-o"></i></span>
565565
</div>
@@ -607,7 +607,7 @@
607607
<div class="form-group row">
608608
<div class="col-md-12">
609609
<div class="input-group">
610-
<input type="email" id="input2-group2" name="input2-group2" class="form-control" placeholder="Email">
610+
<input type="email" id="input2-group2" name="input2-group2" class="form-control" placeholder="Email" autocomplete="email">
611611
<span class="input-group-append">
612612
<button type="button" class="btn btn-primary">Submit</button>
613613
</span>
@@ -665,7 +665,7 @@
665665
<div class="form-group row">
666666
<div class="col-md-12">
667667
<div class="input-group">
668-
<input type="email" id="input2-group3" name="input2-group3" class="form-control" placeholder="Email">
668+
<input type="email" id="input2-group3" name="input2-group3" class="form-control" placeholder="Email" autocomplete="email">
669669
<div class="input-group-append" dropdown>
670670
<button type="button" class="btn btn-primary dropdown-toggle" dropdownToggle>Action
671671
<span class="caret"></span>
@@ -873,7 +873,7 @@
873873
<div class="input-group-prepend">
874874
<span class="input-group-text">Email</span>
875875
</div>
876-
<input type="email" id="email3" name="email3" class="form-control">
876+
<input type="email" id="email3" name="email3" class="form-control" autocomplete="email">
877877
<div class="input-group-append">
878878
<span class="input-group-text"><i class="fa fa-envelope"></i></span>
879879
</div>
@@ -884,7 +884,7 @@
884884
<div class="input-group-prepend">
885885
<span class="input-group-text">Password</span>
886886
</div>
887-
<input type="password" id="password3" name="password3" class="form-control">
887+
<input type="password" id="password3" name="password3" class="form-control" autocomplete="current-password">
888888
<div class="input-group-append">
889889
<span class="input-group-text"><i class="fa fa-asterisk"></i></span>
890890
</div>
@@ -914,15 +914,15 @@
914914
</div>
915915
<div class="form-group">
916916
<div class="input-group">
917-
<input type="email" id="email2" name="email2" class="form-control" placeholder="Email">
917+
<input type="email" id="email2" name="email2" class="form-control" placeholder="Email" autocomplete="email">
918918
<div class="input-group-append">
919919
<span class="input-group-text"><i class="fa fa-envelope"></i></span>
920920
</div>
921921
</div>
922922
</div>
923923
<div class="form-group">
924924
<div class="input-group">
925-
<input type="password" id="password2" name="password2" class="form-control" placeholder="Password">
925+
<input type="password" id="password2" name="password2" class="form-control" placeholder="Password" autocomplete="current-password">
926926
<div class="input-group-append">
927927
<span class="input-group-text"><i class="fa fa-asterisk"></i></span>
928928
</div>
@@ -955,15 +955,15 @@
955955
<div class="input-group-prepend">
956956
<span class="input-group-text"><i class="fa fa-envelope"></i></span>
957957
</div>
958-
<input type="email" id="email" name="email" class="form-control" placeholder="Email">
958+
<input type="email" id="email" name="email" class="form-control" placeholder="Email" autocomplete="email">
959959
</div>
960960
</div>
961961
<div class="form-group">
962962
<div class="input-group">
963963
<div class="input-group-prepend">
964964
<span class="input-group-text"><i class="fa fa-asterisk"></i></span>
965965
</div>
966-
<input type="password" id="password" name="password" class="form-control" placeholder="Password">
966+
<input type="password" id="password" name="password" class="form-control" placeholder="Password" autocomplete="current-password">
967967
</div>
968968
</div>
969969
<div class="form-group form-actions">

Diff for: ‎src/app/views/login/login.component.html

+21-19
Original file line numberDiff line numberDiff line change
@@ -6,28 +6,30 @@
66
<div class="card-group">
77
<div class="card p-4">
88
<div class="card-body">
9-
<h1>Login</h1>
10-
<p class="text-muted">Sign In to your account</p>
11-
<div class="input-group mb-3">
12-
<div class="input-group-prepend">
13-
<span class="input-group-text"><i class="icon-user"></i></span>
9+
<form>
10+
<h1>Login</h1>
11+
<p class="text-muted">Sign In to your account</p>
12+
<div class="input-group mb-3">
13+
<div class="input-group-prepend">
14+
<span class="input-group-text"><i class="icon-user"></i></span>
15+
</div>
16+
<input type="text" class="form-control" placeholder="Username" autocomplete="username" required>
1417
</div>
15-
<input type="text" class="form-control" placeholder="Username">
16-
</div>
17-
<div class="input-group mb-4">
18-
<div class="input-group-prepend">
19-
<span class="input-group-text"><i class="icon-lock"></i></span>
20-
</div>
21-
<input type="password" class="form-control" placeholder="Password">
22-
</div>
23-
<div class="row">
24-
<div class="col-6">
25-
<button type="button" class="btn btn-primary px-4">Login</button>
18+
<div class="input-group mb-4">
19+
<div class="input-group-prepend">
20+
<span class="input-group-text"><i class="icon-lock"></i></span>
21+
</div>
22+
<input type="password" class="form-control" placeholder="Password" autocomplete="current-password" required>
2623
</div>
27-
<div class="col-6 text-right">
28-
<button type="button" class="btn btn-link px-0">Forgot password?</button>
24+
<div class="row">
25+
<div class="col-6">
26+
<button type="button" class="btn btn-primary px-4">Login</button>
27+
</div>
28+
<div class="col-6 text-right">
29+
<button type="button" class="btn btn-link px-0">Forgot password?</button>
30+
</div>
2931
</div>
30-
</div>
32+
</form>
3133
</div>
3234
</div>
3335
<div class="card text-white bg-primary py-5 d-md-down-none" style="width:44%">

Diff for: ‎src/app/views/register/register.component.html

+25-23
Original file line numberDiff line numberDiff line change
@@ -5,33 +5,35 @@
55
<div class="col-md-6 mx-auto">
66
<div class="card mx-4">
77
<div class="card-body p-4">
8-
<h1>Register</h1>
9-
<p class="text-muted">Create your account</p>
10-
<div class="input-group mb-3">
11-
<div class="input-group-prepend">
12-
<span class="input-group-text"><i class="icon-user"></i></span>
8+
<form>
9+
<h1>Register</h1>
10+
<p class="text-muted">Create your account</p>
11+
<div class="input-group mb-3">
12+
<div class="input-group-prepend">
13+
<span class="input-group-text"><i class="icon-user"></i></span>
14+
</div>
15+
<input type="text" class="form-control" placeholder="Username" autocomplete="username" required>
1316
</div>
14-
<input type="text" class="form-control" placeholder="Username">
15-
</div>
16-
<div class="input-group mb-3">
17-
<div class="input-group-prepend">
18-
<span class="input-group-text">@</span>
17+
<div class="input-group mb-3">
18+
<div class="input-group-prepend">
19+
<span class="input-group-text">@</span>
20+
</div>
21+
<input type="text" class="form-control" placeholder="Email" autocomplete="email" required>
1922
</div>
20-
<input type="text" class="form-control" placeholder="Email">
21-
</div>
22-
<div class="input-group mb-3">
23-
<div class="input-group-prepend">
24-
<span class="input-group-text"><i class="icon-lock"></i></span>
23+
<div class="input-group mb-3">
24+
<div class="input-group-prepend">
25+
<span class="input-group-text"><i class="icon-lock"></i></span>
26+
</div>
27+
<input type="password" class="form-control" placeholder="Password" autocomplete="new-password" required>
2528
</div>
26-
<input type="password" class="form-control" placeholder="Password">
27-
</div>
28-
<div class="input-group mb-4">
29-
<div class="input-group-prepend">
30-
<span class="input-group-text"><i class="icon-lock"></i></span>
29+
<div class="input-group mb-4">
30+
<div class="input-group-prepend">
31+
<span class="input-group-text"><i class="icon-lock"></i></span>
32+
</div>
33+
<input type="password" class="form-control" placeholder="Repeat password" autocomplete="new-password" required>
3134
</div>
32-
<input type="password" class="form-control" placeholder="Repeat password">
33-
</div>
34-
<button type="button" class="btn btn-block btn-success">Create Account</button>
35+
<button type="button" class="btn btn-block btn-success">Create Account</button>
36+
</form>
3537
</div>
3638
<div class="card-footer p-4">
3739
<div class="row">

0 commit comments

Comments
 (0)