Skip to content

Accessibility option - add Pause capability to Carousel by keyboard/user interaction not by mouse #214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
baloo32 opened this issue Feb 5, 2025 · 6 comments
Assignees

Comments

@baloo32
Copy link

baloo32 commented Feb 5, 2025

The Carousel is great but it's use fails a Web Content Accessibility Guidelines (WCAG) 2 Level AA Conformance accessibility review due to the inability to programmatically pause the carousel outside of on mouse hover.

If you set the interval value to 0, the code doesn't ever recheck the value if it is subsequently changed to a positive value again, so while it is possible to stop the transitions, there is no way to restart them?

@baloo32 baloo32 changed the title Accessibility option - add Pause capability to Carousel by keyboard/user interaction bot by mouse Accessibility option - add Pause capability to Carousel by keyboard/user interaction not by mouse Feb 5, 2025
@xidedix xidedix self-assigned this Feb 6, 2025
@xidedix xidedix closed this as completed in c8a4686 Feb 6, 2025
@xidedix
Copy link
Member

xidedix commented Feb 6, 2025

@baloo32 Thanks for the heads-up!

  • Fixed in 5.3.12
    Please let us know if this works for you. If not, reopen the issue.

@baloo32
Copy link
Author

baloo32 commented Feb 7, 2025

Unfortunately after setting interval to 0, resetting back doesn't restart the timer.

Image
Screen above shows interval setting (2000 - 2 seconds).

Clicking Pause sets the interval value to 0. Carousel does pause (sometimes, not everytime it advances one more slide before pausing).

Image

Clicking Pause again resets the interval value back to 2000 however it doesn't resume transitions.

Image

Image

Don't have permissions to reopen this issue...

Thx

@baloo32
Copy link
Author

baloo32 commented Feb 7, 2025

So I can see on puase it resets the timer; however on unpause, when it calls setTimer the check for the interval value is pulled from this.activeItemInterval which is set as 0 (and not updated from the intial config interval).

Image

@baloo32
Copy link
Author

baloo32 commented Feb 7, 2025

@xidedix sorry, can't reopen this issue - no permission.

@xidedix xidedix reopened this Feb 7, 2025
@xidedix
Copy link
Member

xidedix commented Feb 7, 2025

@baloo32, it should work with version 5.3.14. Please let us know if the issue persists.

@baloo32
Copy link
Author

baloo32 commented Feb 10, 2025

Hi; yes just updated to 5.3.14 and the "unpause" now works as expected.

Many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants