Skip to content

Add AppSidebarNavComponent/AppSidebarMinimizer to public api #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
coyoteecd opened this issue Jul 14, 2020 · 1 comment · Fixed by #112
Closed

Add AppSidebarNavComponent/AppSidebarMinimizer to public api #110

coyoteecd opened this issue Jul 14, 2020 · 1 comment · Fixed by #112

Comments

@coyoteecd
Copy link
Contributor

These are components I directly embed in my app's layout.

Reason: for unit testing, I need to import them in my spec file (to e.g. inspect navItems input parameter and verify that it was passed with the correct items). Trying to import @coreui\angular\lib\sidebar\app-sidebar-nav.component does not work due to webpack (I think). For now I hacked around by importing the generated alias:

import { ɵq } from '@coreui/angular';

I am willing to submit a pull request - it's just a simple change - if you are okay with the suggestion and willing to publish it.

@xidedix
Copy link
Member

xidedix commented Jul 14, 2020

@coyoteecd you are welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants