Skip to content

Commit 51a7029

Browse files
committed
refactor: minor cleanups - typings, tests
1 parent 9244b9b commit 51a7029

File tree

7 files changed

+8
-12
lines changed

7 files changed

+8
-12
lines changed

projects/coreui-angular/src/lib/button/button-close.directive.spec.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,7 @@ import { By } from '@angular/platform-browser';
66
class MockElementRef extends ElementRef {}
77

88
@Component({
9-
template: `
10-
<button cButtonClose></button>`
9+
template: '<button cButtonClose></button>'
1110
})
1211
class TestComponent {}
1312

projects/coreui-icons-angular/src/lib/icon-set/icon-set.service.ts

+2-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,8 @@ export class IconSetService {
1313

1414
public get iconNames() {
1515
return this._iconNames;
16-
};
16+
}
17+
1718
private _iconNames: { [key: string]: string } = {};
1819

1920
get icons(): IIconSet {

projects/coreui-icons-angular/src/lib/icon/icon.component.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -95,12 +95,12 @@ export class IconComponent implements IIcon, AfterViewInit {
9595
return this.size === 'custom' || addCustom ? 'custom-size' : this.size;
9696
}
9797

98-
get computedClasses(): any {
98+
get computedClasses() {
9999
const classes = {
100100
icon: true,
101101
[`icon-${this.computedSize}`]: !!this.computedSize
102102
};
103-
return !!this.customClasses ? this.customClasses : classes;
103+
return !this.customClasses ? classes : this.customClasses;
104104
}
105105

106106
toCamelCase(str: string): string {

projects/coreui-icons-angular/src/lib/icon/icon.directive.spec.ts

-2
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ class TestComponent {
2121
}
2222

2323
describe('IconDirective', () => {
24-
let component: TestComponent;
2524
let fixture: ComponentFixture<TestComponent>;
2625
let svgEl: DebugElement;
2726
let renderer: Renderer2;
@@ -36,7 +35,6 @@ describe('IconDirective', () => {
3635
}).compileComponents();
3736

3837
fixture = TestBed.createComponent(TestComponent);
39-
component = fixture.componentInstance;
4038
fixture.detectChanges();
4139
svgEl = fixture.debugElement.query(By.css('svg'));
4240
renderer = fixture.componentRef.injector.get(Renderer2 as Type<Renderer2>);

projects/coreui-icons-angular/src/lib/icon/icon.directive.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -95,12 +95,12 @@ export class IconDirective implements IIcon {
9595
return this.size === 'custom' || addCustom ? 'custom-size' : this.size;
9696
}
9797

98-
get computedClasses(): any {
98+
get computedClasses() {
9999
const classes = {
100100
icon: true,
101101
[`icon-${this.computedSize}`]: !!this.computedSize
102102
};
103-
return !!this.customClasses ? this.customClasses : classes;
103+
return !this.customClasses ? classes : this.customClasses;
104104
}
105105

106106
toCamelCase(str: string): string {

projects/coreui-icons-angular/src/lib/icon/icon.utils.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
export function toCamelCase(str: string): any {
1+
export function toCamelCase(str: string) {
22
return str.replace(/([-_][a-z0-9])/ig, ($1: string) => {
33
return $1.toUpperCase().replace('-', '');
44
});

projects/coreui-icons-angular/src/lib/shared/html-attr.directive.spec.ts

-2
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ class TestComponent {}
1212

1313
describe('HtmlAttributesDirective', () => {
1414

15-
let component: TestComponent;
1615
let fixture: ComponentFixture<TestComponent>;
1716
let inputEl: DebugElement;
1817
let renderer: Renderer2;
@@ -23,7 +22,6 @@ describe('HtmlAttributesDirective', () => {
2322
imports: [HtmlAttributesDirective]
2423
});
2524
fixture = TestBed.createComponent(TestComponent);
26-
component = fixture.componentInstance;
2725
inputEl = fixture.debugElement.query(By.css('div'));
2826
renderer = fixture.componentRef.injector.get(Renderer2 as Type<Renderer2>);
2927
});

0 commit comments

Comments
 (0)