Skip to content

Commit 32c8aa3

Browse files
committed
fix(animations): remove non animatable overflow
1 parent 4aab262 commit 32c8aa3

File tree

4 files changed

+11
-10
lines changed

4 files changed

+11
-10
lines changed
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
11
:host {
22
display: block;
3+
overflow: hidden;
34
}

projects/coreui-angular/src/lib/alert/alert.component.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,9 @@ type AnimateType = ('hide' | 'show');
2424
exportAs: 'cAlert',
2525
animations: [
2626
trigger('fadeInOut', [
27-
state('show', style({opacity: 1, height: '*', padding: '*', border: '*', margin: '*', overflow: 'hidden'})),
28-
state('hide', style({opacity: 0, height: 0, padding: 0, border: 0, margin: 0, overflow: 'hidden'})),
29-
state('void', style({opacity: 0, height: 0, padding: 0, border: 0, margin: 0, overflow: 'hidden'})),
27+
state('show', style({opacity: 1, height: '*', padding: '*', border: '*', margin: '*'})),
28+
state('hide', style({opacity: 0, height: 0, padding: 0, border: 0, margin: 0})),
29+
state('void', style({opacity: 0, height: 0, padding: 0, border: 0, margin: 0})),
3030
transition('show => hide', [
3131
animate('.3s ease-out'),
3232
]),

projects/coreui-angular/src/lib/collapse/collapse.animations.ts

+4-4
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,17 @@
11
import { animation, animate, style } from '@angular/animations';
22

33
export const expandAnimation = animation([
4-
style({ height: 0, visibility: 'hidden', overflow: 'hidden', paddingTop: 0, paddingBottom: 0 }),
4+
style({ height: 0, visibility: 'hidden', paddingTop: 0, paddingBottom: 0 }),
55
animate('{{ time }} {{ easing }}', style({ height: '*', visibility: 'visible', paddingTop: '*', paddingBottom: '*', minHeight: '*' })
66
),
7-
animate('{{ time }}', style({opacity: '*', overflow: '*'})),
7+
animate('{{ time }}', style({opacity: '*'})),
88
]);
99

1010
export const collapseAnimation = animation([
11-
style({ height: '*', visibility: 'visible', overflow: 'hidden', paddingTop: '*', paddingBottom: '*', minHeight: '*' }),
11+
style({ height: '*', visibility: 'visible', paddingTop: '*', paddingBottom: '*', minHeight: '*' }),
1212
animate(
1313
'{{ time }} {{ easing }}',
14-
style({ height: 0, visibility: 'hidden', opacity: 0, overflow: 'hidden', paddingTop: 0, paddingBottom: 0, minHeight: 0 })
14+
style({ height: 0, visibility: 'hidden', opacity: 0, paddingTop: 0, paddingBottom: 0, minHeight: 0 })
1515
)
1616
]);
1717

projects/coreui-angular/src/lib/toast/toast/toast.component.ts

+3-3
Original file line numberDiff line numberDiff line change
@@ -28,9 +28,9 @@ type AnimateType = ('hide' | 'show');
2828
exportAs: 'cToast',
2929
animations: [
3030
trigger('fadeInOut', [
31-
state('show', style({opacity: 1, height: '*', padding: '*', border: '*', margin: '*', overflow: 'hidden'})),
32-
state('hide', style({opacity: 0, height: 0, padding: 0, border: 0, margin: 0, overflow: 'hidden'})),
33-
state('void', style({opacity: 0, height: 0, padding: 0, border: 0, margin: 0, overflow: 'hidden'})),
31+
state('show', style({opacity: 1, height: '*', padding: '*', border: '*', margin: '*'})),
32+
state('hide', style({opacity: 0, height: 0, padding: 0, border: 0, margin: 0})),
33+
state('void', style({opacity: 0, height: 0, padding: 0, border: 0, margin: 0})),
3434
transition('show => hide', [
3535
animate('{{ time }} {{ easing }}'),
3636
], {

0 commit comments

Comments
 (0)