Skip to content

Commit d080584

Browse files
feat(lint): make parser errors a error rule
1 parent f490ed0 commit d080584

File tree

1 file changed

+14
-8
lines changed

1 file changed

+14
-8
lines changed

lint/linter.go

Lines changed: 14 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -16,10 +16,7 @@ func New(conf *Config, rules []Rule) (*Linter, error) {
1616
func (l *Linter) Lint(commitMsg string) (*Failure, error) {
1717
msg, err := Parse(commitMsg)
1818
if err != nil {
19-
if isHeaderErr(err) {
20-
return l.headerErrorRule(commitMsg), nil
21-
}
22-
return nil, err
19+
return l.parserErrorRule(commitMsg, err)
2320
}
2421
return l.LintCommit(msg)
2522
}
@@ -49,10 +46,19 @@ func (l *Linter) runRule(rule Rule, severity Severity, msg *Commit) (*RuleFailur
4946
return res, false
5047
}
5148

52-
func (l *Linter) headerErrorRule(commitMsg string) *Failure {
53-
// TODO: show more information
49+
func (l *Linter) parserErrorRule(commitMsg string, err error) (*Failure, error) {
5450
res := newFailure(commitMsg)
55-
ruleFail := newRuleFailure("parser", "commit header is not valid", SeverityError)
51+
52+
var errMsg string
53+
if isHeaderErr(err) {
54+
// TODO: show more information
55+
errMsg = "commit header is not in valid format"
56+
} else {
57+
errMsg = err.Error()
58+
}
59+
60+
ruleFail := newRuleFailure("parser", errMsg, SeverityError)
5661
res.add(ruleFail)
57-
return res
62+
63+
return res, nil
5864
}

0 commit comments

Comments
 (0)