From 312a4824c703142396c7475694aa02dbbb0912c3 Mon Sep 17 00:00:00 2001 From: Armano Date: Fri, 7 Feb 2020 20:00:12 +0100 Subject: [PATCH] refactor: use native Object.entries instead of lodash/toPairs --- @commitlint/lint/package.json | 3 +-- @commitlint/lint/src/lint.ts | 5 ++--- @commitlint/load/src/load.ts | 3 +-- @commitlint/prompt/src/library/format.js | 3 +-- @commitlint/prompt/src/library/meta.js | 3 +-- 5 files changed, 6 insertions(+), 11 deletions(-) diff --git a/@commitlint/lint/package.json b/@commitlint/lint/package.json index 4b7b230e3a..9f0710bc4e 100644 --- a/@commitlint/lint/package.json +++ b/@commitlint/lint/package.json @@ -45,7 +45,6 @@ "@commitlint/is-ignored": "^8.3.5", "@commitlint/parse": "^8.3.4", "@commitlint/rules": "^8.3.4", - "@commitlint/types": "^8.3.4", - "lodash": "^4.17.15" + "@commitlint/types": "^8.3.4" } } diff --git a/@commitlint/lint/src/lint.ts b/@commitlint/lint/src/lint.ts index 5ac511d9fa..f216c7996e 100644 --- a/@commitlint/lint/src/lint.ts +++ b/@commitlint/lint/src/lint.ts @@ -2,7 +2,6 @@ import util from 'util'; import isIgnored from '@commitlint/is-ignored'; import parse from '@commitlint/parse'; import defaultRules from '@commitlint/rules'; -import toPairs from 'lodash/toPairs'; import {buildCommitMesage} from './commit-message'; import { LintRuleConfig, @@ -64,7 +63,7 @@ export default async function lint( ); } - const invalid = toPairs(rulesConfig) + const invalid = Object.entries(rulesConfig) .map(([name, config]) => { if (!Array.isArray(config)) { return new Error( @@ -131,7 +130,7 @@ export default async function lint( } // Validate against all rules - const results = toPairs(rulesConfig) + const results = Object.entries(rulesConfig) .filter(([, [level]]) => level > 0) .map(entry => { const [name, config] = entry; diff --git a/@commitlint/load/src/load.ts b/@commitlint/load/src/load.ts index 7f03536529..ae083b0692 100644 --- a/@commitlint/load/src/load.ts +++ b/@commitlint/load/src/load.ts @@ -1,6 +1,5 @@ import Path from 'path'; -import toPairs from 'lodash/toPairs'; import merge from 'lodash/merge'; import mergeWith from 'lodash/mergeWith'; import pick from 'lodash/pick'; @@ -94,7 +93,7 @@ export default async function load( const rules = preset.rules ? preset.rules : {}; const qualifiedRules = (await Promise.all( - toPairs(rules || {}).map(entry => executeRule(entry)) + Object.entries(rules || {}).map(entry => executeRule(entry)) )).reduce((registry, item) => { const [key, value] = item as any; (registry as any)[key] = value; diff --git a/@commitlint/prompt/src/library/format.js b/@commitlint/prompt/src/library/format.js index dfab8add54..75919e1ba5 100644 --- a/@commitlint/prompt/src/library/format.js +++ b/@commitlint/prompt/src/library/format.js @@ -1,5 +1,4 @@ import chalk from 'chalk'; -import toPairs from 'lodash/toPairs'; export default format; @@ -11,7 +10,7 @@ export default format; */ function format(input, debug = false) { const results = debug - ? toPairs(input).reduce((registry, item) => { + ? Object.entries(input || {}).reduce((registry, item) => { const [name, value] = item; registry[name] = value === null ? chalk.grey(`<${name}>`) : chalk.bold(value); diff --git a/@commitlint/prompt/src/library/meta.js b/@commitlint/prompt/src/library/meta.js index f463734efb..bf278bbb5d 100644 --- a/@commitlint/prompt/src/library/meta.js +++ b/@commitlint/prompt/src/library/meta.js @@ -1,5 +1,4 @@ import chalk from 'chalk'; -import toPairs from 'lodash/toPairs'; /** * Get formatted meta hints for configuration @@ -8,7 +7,7 @@ import toPairs from 'lodash/toPairs'; */ export default function meta(settings) { return chalk.grey( - toPairs(settings) + Object.entries(settings || {}) .filter(item => item[1]) .map(item => { const [name, value] = item;