From 9d1058cbea778e2d1a611bdcc14c030ecd32dbe1 Mon Sep 17 00:00:00 2001 From: Frazer Smith Date: Thu, 27 Feb 2025 20:25:35 +0000 Subject: [PATCH] perf: use `node:` prefix to bypass require.cache call for builtins --- @alias/commitlint/cli.test.js | 6 +++--- @commitlint/cli/index.cjs | 2 +- @commitlint/cli/src/cli.test.ts | 6 +++--- @commitlint/cli/src/cli.ts | 8 ++++---- @commitlint/config-conventional/src/index.test.ts | 4 ++-- @commitlint/config-lerna-scopes/index.js | 4 ++-- @commitlint/config-lerna-scopes/index.test.js | 4 ++-- @commitlint/config-nx-scopes/index.test.js | 4 ++-- @commitlint/config-patternplate/index.js | 2 +- @commitlint/config-pnpm-scopes/index.js | 2 +- @commitlint/config-pnpm-scopes/index.test.js | 4 ++-- @commitlint/config-rush-scopes/index.js | 2 +- @commitlint/config-rush-scopes/index.test.js | 4 ++-- @commitlint/config-validator/src/validate.ts | 2 +- @commitlint/config-workspace-scopes/index.js | 4 ++-- @commitlint/config-workspace-scopes/index.test.js | 4 ++-- @commitlint/ensure/src/index.test.ts | 4 ++-- @commitlint/lint/src/lint.ts | 2 +- @commitlint/load/src/load.test.ts | 6 +++--- @commitlint/load/src/load.ts | 2 +- @commitlint/load/src/utils/load-config.ts | 4 ++-- @commitlint/load/src/utils/load-plugin.ts | 6 +++--- @commitlint/load/src/utils/plugin-naming.ts | 2 +- @commitlint/prompt-cli/cli.test.js | 2 +- @commitlint/prompt/src/inquirer/InputCustomPrompt.ts | 2 +- @commitlint/read/src/get-edit-file-path.ts | 4 ++-- @commitlint/read/src/read.test.ts | 2 +- @commitlint/read/src/stream-to-promise.ts | 2 +- @commitlint/resolve-extends/src/index.test.ts | 2 +- @commitlint/resolve-extends/src/index.ts | 6 +++--- @commitlint/rules/src/index.test.ts | 6 +++--- @commitlint/rules/src/trailer-exists.ts | 2 +- @commitlint/top-level/src/index.ts | 2 +- @commitlint/travis-cli/src/cli.test.ts | 6 +++--- @commitlint/travis-cli/src/cli.ts | 2 +- @packages/test/src/fix.ts | 2 +- @packages/test/src/index.test.ts | 4 ++-- @packages/test/src/npm.ts | 2 +- @packages/utils/dep-check.js | 2 +- @packages/utils/pkg-check.js | 8 ++++---- 40 files changed, 72 insertions(+), 72 deletions(-) diff --git a/@alias/commitlint/cli.test.js b/@alias/commitlint/cli.test.js index 8a04c7314b..5f0674233b 100644 --- a/@alias/commitlint/cli.test.js +++ b/@alias/commitlint/cli.test.js @@ -1,7 +1,7 @@ import {test, expect} from 'vitest'; -import {createRequire} from 'module'; -import path from 'path'; -import {fileURLToPath} from 'url'; +import {createRequire} from 'node:module'; +import path from 'node:path'; +import {fileURLToPath} from 'node:url'; import {x} from 'tinyexec'; import {fix} from '@commitlint/test'; diff --git a/@commitlint/cli/index.cjs b/@commitlint/cli/index.cjs index bc56366369..794879ebf1 100644 --- a/@commitlint/cli/index.cjs +++ b/@commitlint/cli/index.cjs @@ -1,3 +1,3 @@ -const path = require('path'); +const path = require('node:path'); module.exports = path.join(__dirname, 'cli.js'); diff --git a/@commitlint/cli/src/cli.test.ts b/@commitlint/cli/src/cli.test.ts index d2f44c50d4..235e5f8849 100644 --- a/@commitlint/cli/src/cli.test.ts +++ b/@commitlint/cli/src/cli.test.ts @@ -1,7 +1,7 @@ import {describe, test, expect} from 'vitest'; -import {createRequire} from 'module'; -import path from 'path'; -import {fileURLToPath} from 'url'; +import {createRequire} from 'node:module'; +import path from 'node:path'; +import {fileURLToPath} from 'node:url'; import {fix, git} from '@commitlint/test'; import fs from 'fs-extra'; import merge from 'lodash.merge'; diff --git a/@commitlint/cli/src/cli.ts b/@commitlint/cli/src/cli.ts index 93ce1cab36..bce45db4e3 100644 --- a/@commitlint/cli/src/cli.ts +++ b/@commitlint/cli/src/cli.ts @@ -1,7 +1,7 @@ -import {createRequire} from 'module'; -import path from 'path'; -import {fileURLToPath, pathToFileURL} from 'url'; -import util from 'util'; +import {createRequire} from 'node:module'; +import path from 'node:path'; +import {fileURLToPath, pathToFileURL} from 'node:url'; +import util from 'node:util'; import lint from '@commitlint/lint'; import load, {resolveFromSilent, resolveGlobalSilent} from '@commitlint/load'; diff --git a/@commitlint/config-conventional/src/index.test.ts b/@commitlint/config-conventional/src/index.test.ts index 683c401754..a44fe8c59a 100644 --- a/@commitlint/config-conventional/src/index.test.ts +++ b/@commitlint/config-conventional/src/index.test.ts @@ -1,6 +1,6 @@ import {test, expect} from 'vitest'; -import path from 'path'; -import {pathToFileURL} from 'url'; +import path from 'node:path'; +import {pathToFileURL} from 'node:url'; import lint from '@commitlint/lint'; diff --git a/@commitlint/config-lerna-scopes/index.js b/@commitlint/config-lerna-scopes/index.js index b1476cb250..7245d07169 100644 --- a/@commitlint/config-lerna-scopes/index.js +++ b/@commitlint/config-lerna-scopes/index.js @@ -1,5 +1,5 @@ -import {createRequire} from 'module'; -import Path from 'path'; +import {createRequire} from 'node:module'; +import Path from 'node:path'; import {globSync} from 'glob'; import importFrom from 'import-from'; diff --git a/@commitlint/config-lerna-scopes/index.test.js b/@commitlint/config-lerna-scopes/index.test.js index c8428419ad..a15f174d8c 100644 --- a/@commitlint/config-lerna-scopes/index.test.js +++ b/@commitlint/config-lerna-scopes/index.test.js @@ -1,6 +1,6 @@ import {test, expect} from 'vitest'; -import path from 'path'; -import {fileURLToPath} from 'url'; +import path from 'node:path'; +import {fileURLToPath} from 'node:url'; import {npm} from '@commitlint/test'; diff --git a/@commitlint/config-nx-scopes/index.test.js b/@commitlint/config-nx-scopes/index.test.js index 1d9e030c94..22a525f145 100644 --- a/@commitlint/config-nx-scopes/index.test.js +++ b/@commitlint/config-nx-scopes/index.test.js @@ -1,6 +1,6 @@ import {test, expect} from 'vitest'; -import path from 'path'; -import {fileURLToPath} from 'url'; +import path from 'node:path'; +import {fileURLToPath} from 'node:url'; import {npm} from '@commitlint/test'; diff --git a/@commitlint/config-patternplate/index.js b/@commitlint/config-patternplate/index.js index 46d403b4db..b732bf932a 100644 --- a/@commitlint/config-patternplate/index.js +++ b/@commitlint/config-patternplate/index.js @@ -1,4 +1,4 @@ -import path from 'path'; +import path from 'node:path'; import configAngular from '@commitlint/config-angular'; import {glob} from 'glob'; diff --git a/@commitlint/config-pnpm-scopes/index.js b/@commitlint/config-pnpm-scopes/index.js index a4f38d4159..6119f3789f 100644 --- a/@commitlint/config-pnpm-scopes/index.js +++ b/@commitlint/config-pnpm-scopes/index.js @@ -1,4 +1,4 @@ -import path from 'path'; +import path from 'node:path'; import fg from 'fast-glob'; import readYamlFile from 'read-yaml-file'; diff --git a/@commitlint/config-pnpm-scopes/index.test.js b/@commitlint/config-pnpm-scopes/index.test.js index 8607209607..26644ec6fe 100644 --- a/@commitlint/config-pnpm-scopes/index.test.js +++ b/@commitlint/config-pnpm-scopes/index.test.js @@ -1,6 +1,6 @@ import {test, expect} from 'vitest'; -import path from 'path'; -import {fileURLToPath} from 'url'; +import path from 'node:path'; +import {fileURLToPath} from 'node:url'; import {npm} from '@commitlint/test'; diff --git a/@commitlint/config-rush-scopes/index.js b/@commitlint/config-rush-scopes/index.js index 2a79997cd5..f20d64b4b1 100644 --- a/@commitlint/config-rush-scopes/index.js +++ b/@commitlint/config-rush-scopes/index.js @@ -1,4 +1,4 @@ -import Path from 'path'; +import Path from 'node:path'; import fs from 'fs/promises'; import jsonc from 'jsonc'; diff --git a/@commitlint/config-rush-scopes/index.test.js b/@commitlint/config-rush-scopes/index.test.js index 2eb65bdf84..84b2e04bea 100644 --- a/@commitlint/config-rush-scopes/index.test.js +++ b/@commitlint/config-rush-scopes/index.test.js @@ -1,6 +1,6 @@ import {test, expect} from 'vitest'; -import path from 'path'; -import {fileURLToPath} from 'url'; +import path from 'node:path'; +import {fileURLToPath} from 'node:url'; import {npm} from '@commitlint/test'; diff --git a/@commitlint/config-validator/src/validate.ts b/@commitlint/config-validator/src/validate.ts index 47867a3bf7..5eec2704cc 100644 --- a/@commitlint/config-validator/src/validate.ts +++ b/@commitlint/config-validator/src/validate.ts @@ -1,4 +1,4 @@ -import {createRequire} from 'module'; +import {createRequire} from 'node:module'; import {UserConfig} from '@commitlint/types'; import _Ajv from 'ajv'; diff --git a/@commitlint/config-workspace-scopes/index.js b/@commitlint/config-workspace-scopes/index.js index 4fc08b4cc4..c365c099d6 100644 --- a/@commitlint/config-workspace-scopes/index.js +++ b/@commitlint/config-workspace-scopes/index.js @@ -1,5 +1,5 @@ -import {createRequire} from 'module'; -import Path from 'path'; +import {createRequire} from 'node:module'; +import Path from 'node:path'; import {globSync} from 'glob'; diff --git a/@commitlint/config-workspace-scopes/index.test.js b/@commitlint/config-workspace-scopes/index.test.js index bd59dc0cf0..e969f4dc58 100644 --- a/@commitlint/config-workspace-scopes/index.test.js +++ b/@commitlint/config-workspace-scopes/index.test.js @@ -1,6 +1,6 @@ import {test, expect} from 'vitest'; -import path from 'path'; -import {fileURLToPath} from 'url'; +import path from 'node:path'; +import {fileURLToPath} from 'node:url'; import {npm} from '@commitlint/test'; diff --git a/@commitlint/ensure/src/index.test.ts b/@commitlint/ensure/src/index.test.ts index 859ed49b3a..4267fd7a6e 100644 --- a/@commitlint/ensure/src/index.test.ts +++ b/@commitlint/ensure/src/index.test.ts @@ -1,6 +1,6 @@ import {test, expect} from 'vitest'; -import path from 'path'; -import {fileURLToPath} from 'url'; +import path from 'node:path'; +import {fileURLToPath} from 'node:url'; import {globSync} from 'glob'; import camelCase from 'lodash.camelcase'; diff --git a/@commitlint/lint/src/lint.ts b/@commitlint/lint/src/lint.ts index b61326ce49..7ad92c10c8 100644 --- a/@commitlint/lint/src/lint.ts +++ b/@commitlint/lint/src/lint.ts @@ -1,4 +1,4 @@ -import util from 'util'; +import util from 'node:util'; import isIgnored from '@commitlint/is-ignored'; import parse from '@commitlint/parse'; import defaultRules from '@commitlint/rules'; diff --git a/@commitlint/load/src/load.test.ts b/@commitlint/load/src/load.test.ts index f56850f510..cb7b49b062 100644 --- a/@commitlint/load/src/load.test.ts +++ b/@commitlint/load/src/load.test.ts @@ -1,7 +1,7 @@ import {describe, test, expect, vi} from 'vitest'; -import {readFileSync, writeFileSync} from 'fs'; -import path from 'path'; -import {fileURLToPath} from 'url'; +import {readFileSync, writeFileSync} from 'node:fs'; +import path from 'node:path'; +import {fileURLToPath} from 'node:url'; import {RuleConfigSeverity} from '@commitlint/types'; import {fix, git, npm} from '@commitlint/test'; diff --git a/@commitlint/load/src/load.ts b/@commitlint/load/src/load.ts index 0d63e74f7d..16a08606f0 100644 --- a/@commitlint/load/src/load.ts +++ b/@commitlint/load/src/load.ts @@ -1,4 +1,4 @@ -import path from 'path'; +import path from 'node:path'; import {validateConfig} from '@commitlint/config-validator'; import executeRule from '@commitlint/execute-rule'; diff --git a/@commitlint/load/src/utils/load-config.ts b/@commitlint/load/src/utils/load-config.ts index 34a8af8039..97ba7738ed 100644 --- a/@commitlint/load/src/utils/load-config.ts +++ b/@commitlint/load/src/utils/load-config.ts @@ -1,5 +1,5 @@ -import {existsSync, readFileSync} from 'fs'; -import path from 'path'; +import {existsSync, readFileSync} from 'node:fs'; +import path from 'node:path'; import { cosmiconfig, diff --git a/@commitlint/load/src/utils/load-plugin.ts b/@commitlint/load/src/utils/load-plugin.ts index f13a6d7269..bdaf9f2390 100644 --- a/@commitlint/load/src/utils/load-plugin.ts +++ b/@commitlint/load/src/utils/load-plugin.ts @@ -1,6 +1,6 @@ -import {createRequire} from 'module'; -import path from 'path'; -import {fileURLToPath, pathToFileURL} from 'url'; +import {createRequire} from 'node:module'; +import path from 'node:path'; +import {fileURLToPath, pathToFileURL} from 'node:url'; import {Plugin, PluginRecords} from '@commitlint/types'; import chalk from 'chalk'; diff --git a/@commitlint/load/src/utils/plugin-naming.ts b/@commitlint/load/src/utils/plugin-naming.ts index da2fd2f8a3..17cf43ed5d 100644 --- a/@commitlint/load/src/utils/plugin-naming.ts +++ b/@commitlint/load/src/utils/plugin-naming.ts @@ -1,4 +1,4 @@ -import path from 'path'; +import path from 'node:path'; // largely adapted from eslint's plugin system const NAMESPACE_REGEX = /^@.*\//u; diff --git a/@commitlint/prompt-cli/cli.test.js b/@commitlint/prompt-cli/cli.test.js index 0dc4085f87..787fc47dcc 100644 --- a/@commitlint/prompt-cli/cli.test.js +++ b/@commitlint/prompt-cli/cli.test.js @@ -1,5 +1,5 @@ import {test, expect} from 'vitest'; -import {createRequire} from 'module'; +import {createRequire} from 'node:module'; import {git} from '@commitlint/test'; import {x} from 'tinyexec'; diff --git a/@commitlint/prompt/src/inquirer/InputCustomPrompt.ts b/@commitlint/prompt/src/inquirer/InputCustomPrompt.ts index 6e7824dcdd..05ed36c214 100644 --- a/@commitlint/prompt/src/inquirer/InputCustomPrompt.ts +++ b/@commitlint/prompt/src/inquirer/InputCustomPrompt.ts @@ -4,7 +4,7 @@ import chalk from 'chalk'; import inquirer, {type Answers, type InputCustomOptions} from 'inquirer'; import InputPrompt from 'inquirer/lib/prompts/input.js'; import observe from 'inquirer/lib/utils/events.js'; -import type {Interface as ReadlineInterface, Key} from 'readline'; +import type {Interface as ReadlineInterface, Key} from 'node:readline'; import type {Subscription} from 'rxjs'; import SuccessfulPromptStateData = inquirer.prompts.SuccessfulPromptStateData; diff --git a/@commitlint/read/src/get-edit-file-path.ts b/@commitlint/read/src/get-edit-file-path.ts index 4260b34f5f..191cf6376a 100644 --- a/@commitlint/read/src/get-edit-file-path.ts +++ b/@commitlint/read/src/get-edit-file-path.ts @@ -1,5 +1,5 @@ -import path from 'path'; -import {Stats} from 'fs'; +import path from 'node:path'; +import {Stats} from 'node:fs'; import fs from 'fs/promises'; // Get path to recently edited commit message file diff --git a/@commitlint/read/src/read.test.ts b/@commitlint/read/src/read.test.ts index 9d7fa9a12e..4cf4622edf 100644 --- a/@commitlint/read/src/read.test.ts +++ b/@commitlint/read/src/read.test.ts @@ -1,6 +1,6 @@ import {test, expect} from 'vitest'; import fs from 'fs/promises'; -import path from 'path'; +import path from 'node:path'; import {git} from '@commitlint/test'; import {x} from 'tinyexec'; diff --git a/@commitlint/read/src/stream-to-promise.ts b/@commitlint/read/src/stream-to-promise.ts index afa8c63446..d1610cc7b8 100644 --- a/@commitlint/read/src/stream-to-promise.ts +++ b/@commitlint/read/src/stream-to-promise.ts @@ -1,4 +1,4 @@ -import {Readable} from 'stream'; +import {Readable} from 'node:stream'; export function streamToPromise(stream: Readable): Promise { const data: string[] = []; diff --git a/@commitlint/resolve-extends/src/index.test.ts b/@commitlint/resolve-extends/src/index.test.ts index b088476e00..35ed266d91 100644 --- a/@commitlint/resolve-extends/src/index.test.ts +++ b/@commitlint/resolve-extends/src/index.test.ts @@ -1,5 +1,5 @@ import {test, expect, vi} from 'vitest'; -import {createRequire} from 'module'; +import {createRequire} from 'node:module'; import {RuleConfigSeverity, UserConfig} from '@commitlint/types'; import resolveExtends, {ResolveExtendsContext} from './index.js'; diff --git a/@commitlint/resolve-extends/src/index.ts b/@commitlint/resolve-extends/src/index.ts index a8519ffa6d..f31a3458ca 100644 --- a/@commitlint/resolve-extends/src/index.ts +++ b/@commitlint/resolve-extends/src/index.ts @@ -1,6 +1,6 @@ -import fs from 'fs'; -import path from 'path'; -import {pathToFileURL, fileURLToPath} from 'url'; +import fs from 'node:fs'; +import path from 'node:path'; +import {pathToFileURL, fileURLToPath} from 'node:url'; import globalDirectory from 'global-directory'; import {moduleResolve} from 'import-meta-resolve'; diff --git a/@commitlint/rules/src/index.test.ts b/@commitlint/rules/src/index.test.ts index 822fd53c73..feb4d4088e 100644 --- a/@commitlint/rules/src/index.test.ts +++ b/@commitlint/rules/src/index.test.ts @@ -1,7 +1,7 @@ import {test, expect} from 'vitest'; -import fs from 'fs'; -import path from 'path'; -import {fileURLToPath} from 'url'; +import fs from 'node:fs'; +import path from 'node:path'; +import {fileURLToPath} from 'node:url'; import {globSync} from 'glob'; diff --git a/@commitlint/rules/src/trailer-exists.ts b/@commitlint/rules/src/trailer-exists.ts index 8ca7f7ae56..dca7d1478d 100644 --- a/@commitlint/rules/src/trailer-exists.ts +++ b/@commitlint/rules/src/trailer-exists.ts @@ -1,4 +1,4 @@ -import {spawnSync} from 'child_process'; +import {spawnSync} from 'node:child_process'; import message from '@commitlint/message'; import toLines from '@commitlint/to-lines'; import {SyncRule} from '@commitlint/types'; diff --git a/@commitlint/top-level/src/index.ts b/@commitlint/top-level/src/index.ts index 5e3f3d3e1b..ed71acbad8 100644 --- a/@commitlint/top-level/src/index.ts +++ b/@commitlint/top-level/src/index.ts @@ -1,4 +1,4 @@ -import path from 'path'; +import path from 'node:path'; import {findUp} from 'find-up'; export default toplevel; diff --git a/@commitlint/travis-cli/src/cli.test.ts b/@commitlint/travis-cli/src/cli.test.ts index c6d05e881f..848c47bfdf 100644 --- a/@commitlint/travis-cli/src/cli.test.ts +++ b/@commitlint/travis-cli/src/cli.test.ts @@ -1,9 +1,9 @@ import {SpawnOptions} from 'node:child_process'; import {test, expect} from 'vitest'; -import {createRequire} from 'module'; -import path from 'path'; -import {fileURLToPath} from 'url'; +import {createRequire} from 'node:module'; +import path from 'node:path'; +import {fileURLToPath} from 'node:url'; import {git} from '@commitlint/test'; import {x} from 'tinyexec'; diff --git a/@commitlint/travis-cli/src/cli.ts b/@commitlint/travis-cli/src/cli.ts index 12ce0cf9f8..943b37203b 100644 --- a/@commitlint/travis-cli/src/cli.ts +++ b/@commitlint/travis-cli/src/cli.ts @@ -1,6 +1,6 @@ import {SpawnOptions} from 'node:child_process'; -import {createRequire} from 'module'; +import {createRequire} from 'node:module'; import {x} from 'tinyexec'; diff --git a/@packages/test/src/fix.ts b/@packages/test/src/fix.ts index 762949e836..1227833968 100644 --- a/@packages/test/src/fix.ts +++ b/@packages/test/src/fix.ts @@ -1,4 +1,4 @@ -import path from 'path'; +import path from 'node:path'; import fs from 'fs-extra'; import {packageDirectory as pkgDir} from 'pkg-dir'; diff --git a/@packages/test/src/index.test.ts b/@packages/test/src/index.test.ts index 0ee0b4ae13..9b11836021 100644 --- a/@packages/test/src/index.test.ts +++ b/@packages/test/src/index.test.ts @@ -1,6 +1,6 @@ import {test, expect} from 'vitest'; -import os from 'os'; -import path from 'path'; +import os from 'node:os'; +import path from 'node:path'; import fs from 'fs-extra'; import * as u from './index.js'; diff --git a/@packages/test/src/npm.ts b/@packages/test/src/npm.ts index 997543435d..f017ac32f3 100644 --- a/@packages/test/src/npm.ts +++ b/@packages/test/src/npm.ts @@ -1,4 +1,4 @@ -import path from 'path'; +import path from 'node:path'; import fs from 'fs-extra'; import resolvePkg from 'resolve-pkg'; diff --git a/@packages/utils/dep-check.js b/@packages/utils/dep-check.js index cc9c3bdfe3..833a19ac13 100755 --- a/@packages/utils/dep-check.js +++ b/@packages/utils/dep-check.js @@ -1,5 +1,5 @@ #!/usr/bin/env node -import path from 'path'; +import path from 'node:path'; import {x} from 'tinyexec'; const cwd = process.cwd(); diff --git a/@packages/utils/pkg-check.js b/@packages/utils/pkg-check.js index 8d6b16df32..893bdd07cb 100755 --- a/@packages/utils/pkg-check.js +++ b/@packages/utils/pkg-check.js @@ -1,6 +1,6 @@ #!/usr/bin/env node -import path from 'path'; -import fs from 'fs'; +import path from 'node:path'; +import fs from 'node:fs'; import readPkg from 'read-pkg'; import requireFromString from 'require-from-string'; @@ -8,12 +8,12 @@ import tar from 'tar-fs'; import {x} from 'tinyexec'; import tmp from 'tmp'; import yargs from 'yargs'; -import zlib from 'zlib'; +import zlib from 'node:zlib'; tmp.setGracefulCleanup(); const PRELUDE = ` -var Module = require('module'); +var Module = require('node:module'); var originalLoader = Module._load Module._load = function(path, parent) {