Skip to content

Rename project to a more generic name #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gajus opened this issue Aug 15, 2016 · 7 comments
Closed

Rename project to a more generic name #9

gajus opened this issue Aug 15, 2016 · 7 comments

Comments

@gajus
Copy link

gajus commented Aug 15, 2016

The current project name (conventional-changelog-lint) implies that this tool is designed to be used with conventional-changelog. Regardless of whether thats true or not, the tool itself has potential for broader applications.

A good name would be something like commitlint.

@marionebl
Copy link
Contributor

Hey @gajus, thanks for your suggestion!

I chose the name due to the fact this tool uses conventional-commits-parser under the hood, which basically limits it to conventional-changelog semantics.

To hold true to the commitlint name this would have to be broadened quite a bit and replace conventional-commits-parser with a custom parser, possibly using natural language processing.

Most likely this is a sizeable chunk of work which I'm currently not planing to invest into this topic. Given we can muster some collaboration effort and fill the broader scope I'd rename the project.

@gajus
Copy link
Author

gajus commented Aug 15, 2016

To hold true to the commitlint name this would have to be broadened quite a bit and replace conventional-commits-parser with a custom parser, possibly using natural language processing.
[..]
Given we can muster some collaboration effort and fill the broader scope I'd rename the project.

Do you have specific rules in mind that you think would be required to move from the current project scope to commitlint?

It seems that you already have quite a broad coverage. Even compared to services such as https://gitcop.com/, conventional-changelog-lint implements more rules.

@marionebl
Copy link
Contributor

marionebl commented Aug 15, 2016

I think this of this more as a matter of entanglement with conventional-changelog semantics than of the perceived absolute rule coverage.

Perhaps this is not as relevant as I first thought – I'd have to search for a commit convention that could not be linted with this to prove my point. :trollface:

What type of convention are you testing via conventional-changelog-lint in your projects?

@gajus
Copy link
Author

gajus commented Aug 15, 2016

What type of convention are you testing via conventional-changelog-lint in your projects?

https://gist.github.com/gajus/b57fd0ce6cc6de09867bbc331c4ddaf0#file-conventional-changelog-lintrc-json

Basically, Angular convention minus the scopes.

@marionebl
Copy link
Contributor

Thought about splitting the angular convention in distinct parts - the scopes could be one of them...

@marionebl
Copy link
Contributor

marionebl commented Mar 6, 2017

@marionebl marionebl mentioned this issue Jul 7, 2017
26 tasks
@marionebl
Copy link
Contributor

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

2 participants