You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I noticed with the version 1.0.0 of Conventional Commits, they added a ! in the first line:
BREAKING CHANGE: a commit that has a footer BREAKING CHANGE:, or appends a ! after the type/scope, introduces a breaking API change (correlating with MAJOR in semantic versioning). A BREAKING CHANGE can be part of commits of any type.
On the page, there is an example:
refactor!: drop support for Node 6
BREAKING CHANGE: refactor to use JavaScript features not available in Node 6.
When I run the following command, I would expect it to pass.
$ cat | ./node_modules/.bin/commitlint
refactor!: drop support for Node 6
BREAKING CHANGE: refactor to use JavaScript features not available in Node 6.
^D
$
Current Behavior
$ cat | ./node_modules/.bin/commitlint
refactor!: drop support for Node 6
BREAKING CHANGE: refactor to use JavaScript features not available in Node 6.
^D
⧗ input: refactor!: drop support for Node 6
BREAKING CHANGE: refactor to use JavaScript features not available in Node 6.
✖ subject may not be empty [subject-empty]
✖ type may not be empty [type-empty]
✖ found 2 problems, 0 warnings
ⓘ Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint
$
Affected packages
cli
core
prompt
config-angular
config-conventional
Possible Solution
I'm not sure, maybe a regular expression needs to change?
Hey @dmoonfire , you're right. For now this isn't supported by commitlint.
But we have an upcomming PR for this already: #767
Please be patient, this might take a bit longer :)
@escapedcat I think we need to release the beta version as the latest. I reworked the conventional changelog plugins, which is actually published on the next dist tag. But, I think we are ready for a new release right? 😄
@dmoonfire You can try this version using commitlint 8.3.3, replace the npm install with this:
I noticed with the version 1.0.0 of Conventional Commits, they added a
!
in the first line:On the page, there is an example:
Naturally, I liked that so I tried to use it.
Expected Behavior
The entries in my
package.json
:When I run the following command, I would expect it to pass.
Current Behavior
Affected packages
Possible Solution
I'm not sure, maybe a regular expression needs to change?
Steps to Reproduce (for bugs)
npm install @commitlint/cli@latest @commitlint/config-conventional@latest
echo 'refactor!: test' ./node_modules/.bin/commitlint
Context
I would like to use the new
!
because it communicates something useful to my team.Your Environment
commitlint --version
git --version
node --version
The text was updated successfully, but these errors were encountered: