-
Notifications
You must be signed in to change notification settings - Fork 934
Valid commit message subject is rejected #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
So basically you are saying that $ printf "chore(release): 1.0.1 [skip ci]\n\n## [1.0.1](https://github.com/xmlking/ngx-starter-kit/compare/v1.0.0...v1.0.1) (2018-09-09)\n\n\n### Bug Fixes\n\n* **build:** now updating version ([2d913ea](https://github.com/xmlking/ngx-s
tarter-kit/commit/2d913ea))\n\n\n\n" | npx commitlint -x '@commitlint/config-conventional' I'm not sure if this was intentional, but it looks like the Until this is resolved, you can temporarily work around this by adjusting the {
"commitlint": {
"extends": ["@commitlint/config-conventional"],
"rules": {
"subject-case": [2, "never", ["start-case", "pascal-case", "upper-case"]]
}
}
} |
@byCedric is right, we should ignore characters not matching |
any update in this issue ? |
@xmlking Sorry, I had a bit too much work on my hands these past weeks. Right now, I'm writing a fix for this. Please stick with us here! 😄 |
Expected Behavior
Subject starts with 1.0.1 should be considered valid
Current Behavior
printf "chore(release): 1.0.1 [skip ci]\n\n## 1.0.1 (2018-09-09)\n\n\n### Bug Fixes\n\n* build: now updating version (2d913ea)\n\n\n\n" | npx commitlint
This give error
Also reported here:
semantic-release/semantic-release#928 (comment)
Affected packages
Possible Solution
Steps to Reproduce (for bugs)
https://github.com/xmlking/ngx-starter-kit/blob/master/package.json
commitlint.config.js
```js ```Context
Your Environment
commitlint --version
git --version
node --version
The text was updated successfully, but these errors were encountered: