Skip to content

fix: commitlint is not working #4085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 4 tasks
jefersoneiji opened this issue May 15, 2024 · 4 comments
Closed
1 of 4 tasks

fix: commitlint is not working #4085

jefersoneiji opened this issue May 15, 2024 · 4 comments
Labels

Comments

@jefersoneiji
Copy link
Contributor

jefersoneiji commented May 15, 2024

Steps to Reproduce

  1. First step: Access the getting started section from commitlint

  2. Second step: Follow all the installation/setup steps

Current Behavior

Commitlint apparently doesn't even run when commit-msg is called

Expected Behavior

To throw errors or warning whenever something is wrong.

Affected packages

  • cli
  • core
  • prompt
  • config-angular

Possible Solution

No response

Context

I installed it in a vite + react.js project

commitlint --version

"@commitlint/cli": "^19.3.0",

git --version

2.32.0.windows.1

node --version

20.11.1

@escapedcat
Copy link
Member

Can the docs be improved somehow?

@jefersoneiji
Copy link
Contributor Author

jefersoneiji commented May 16, 2024

Can the docs be improved somehow?

Yes. I'm a windows user. MacOS and Windows encoding for files tend to be different. After taking a look my encoding was UTF-16 LE. Switching it back to UTF-8 solved the problem. I had to manually rewrite the husky commit-msg file. My code editor is VSCode by the way.

@escapedcat
Copy link
Member

Ah yes, here's the issue: #788
Happy for a PR to the docs :)

@jefersoneiji
Copy link
Contributor Author

Waiting for you to merge it #4086

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants