-
Notifications
You must be signed in to change notification settings - Fork 934
Error when using Lerna 3.0 #405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Judging from https://github.com/lerna/lerna/blob/master/core/project/index.js, the updated code should probably look something like this:
Should I open a PR for this? Or are you working on an update to 3.0 anyway? UPDATE: I have opened a PR to demonstrate possible changes: https://github.com/marionebl/commitlint/pull/406 |
@backflip Thanks for your proposed solution and the PR. I went with an approach that keeps lerna v2 support around for the time being. The improvements / fixes are released via 7.1.0. |
When using Commitlint in a monorepo with Lerna
3.0.0-rc.0
, the following error occurs:Expected Behavior
As soon as Lerna 3 is stable, https://github.com/marionebl/commitlint/tree/master/%40commitlint/config-lerna-scopes should be updated to work with it.
Current Behavior
The current code in https://github.com/marionebl/commitlint/tree/master/%40commitlint/config-lerna-scopes is not compatible with Lerna 3.
Affected packages
Possible Solution
Figure out how Lerna 3 exposes package names.
Steps to Reproduce (for bugs)
Context
I want to be able to update a Lerna monorepo to v3.
Your Environment
commitlint --version
git --version
node --version
The text was updated successfully, but these errors were encountered: