Skip to content

fix: from to feature does not detect violations properly #3924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 4 tasks
holomekc opened this issue Feb 19, 2024 · 6 comments
Closed
1 of 4 tasks

fix: from to feature does not detect violations properly #3924

holomekc opened this issue Feb 19, 2024 · 6 comments
Labels

Comments

@holomekc
Copy link

holomekc commented Feb 19, 2024

Expected Behavior

When using commitlint with --from and --to it should detect violations if one commit message is not formatted properly

Current Behavior

When using:
commitlint --from 67fc95423dd3ec1f073dab2df304bf4f8a3c4063~2 --to 67fc95423dd3ec1f073dab2df304bf4f8a3c4063 --verbose --color

Everything is happy:
image

When using:
commitlint -e
It is not ok:
image

Affected packages

  • cli
  • core
  • prompt
  • config-angular

Possible Solution

No response

Steps to Reproduce

1. Two commits one ok the second violates the rules
2. Run with from to.

Context

No response

commitlint --version

18.6.1

git --version

2.39.3

node --version

v20.11.0

@holomekc holomekc added the bug label Feb 19, 2024
@knocte
Copy link
Contributor

knocte commented Feb 19, 2024

This is a duplicate of #3376

@escapedcat escapedcat closed this as not planned Won't fix, can't repro, duplicate, stale Feb 19, 2024
@holomekc
Copy link
Author

holomekc commented Feb 19, 2024

Hi @knocte, @escapedcat

Sorry then it was a stupid example from my side:
commitlint --from 4f038290da73f58fe58bef2768ce20d3efc21ff8 --to 3834600cc108dcf8ac9c9d6d09f1710fcb744e09

And two commits:
image

it works with 18.6.0 but not with 18.6.1 for us.

@knocte
Copy link
Contributor

knocte commented Feb 19, 2024

Have you tried 18.6.2? there was a regression in 18.6.1

@holomekc
Copy link
Author

holomekc commented Feb 19, 2024

It is not available in npm. There seems to be a mistake in the latest release:
https://www.npmjs.com/package/@commitlint/cli
image

@knocte
Copy link
Contributor

knocte commented Feb 20, 2024

@escapedcat ping ^

@escapedcat
Copy link
Member

Not all packages were updated. That's normal. Relevant packages are available in 18.6.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

3 participants