fix: commitlint --extends is ignored for commitlint/config-conventional (v18.6.1)

[nwrkbiz]

Expected Behavior

Commits shall be linted.

Current Behavior

Error: Please add rules to your commitlint.config.js

Affected packages

• cli
• core
• prompt
• config-angular

Possible Solution

No response

Steps to Reproduce

npm install -g @commitlint/cli @commitlint/config-conventional
commitlint -V --extends @commitlint/config-conventional --from=HEAD~1 --to HEAD

Context

The steps to reproduce worked in the last version (18.6.0)

commitlint --version

@commitlint/[email protected]

git --version

2.39.2

node --version

10.2.3

[nwrkbiz]

I could narrow this down: The problem is caused by the @commitlint/[email protected] package if I dowgrade this to @commitlint/[email protected] everything works again.

[nwrkbiz]

Looks like the refactoring to typescript caused the problem: 345bcf5

In js the ruleset was defined in module.exports in typescript everything now is in exports.config.

[escapedcat]

The PR creator was informed. Happy for anyone else who wants to fix this.

[dargmuesli]

Something like this? #3911

[damienbutt]

I've always used a .commitlintrc.json for my config.

{
    "extends": ["@commitlint/config-conventional"]
}

Executing commitlint via a commit-msg hook using Husky.

#!/usr/bin/env sh
. "$(dirname -- "$0")/_/husky.sh"

pnpm commitlint --edit $1

On 18.6.0, this works.

But on 18.6.1, it breaks.

✖   Please add rules to your `commitlint.config.js`
    - Getting started guide: https://commitlint.js.org/#/?id=getting-started
    - Example config: https://github.com/conventional-changelog/commitlint/blob/master/%40commitlint/config-conventional/src/index.ts [empty-rules]

✖   found 1 problems, 0 warnings
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

Running it from the CLI produces the same error.

echo "chore: bump deps" | pnpm commitlint
✖   Please add rules to your `commitlint.config.js`
    - Getting started guide: https://commitlint.js.org/#/?id=getting-started
    - Example config: https://github.com/conventional-changelog/commitlint/blob/master/%40commitlint/config-conventional/src/index.ts [empty-rules]

✖   found 1 problems, 0 warnings
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint

Re-added this as realised it only relates to 18.6.1. 18.6.0 works as expected.

[ryancausey]

It looks like this broke my CI as well.

$ npm install --global @commitlint/config-conventional @commitlint/cli
added 199 packages in 8s
31 packages are looking for funding
  run `npm fund` for details
$ npm --version
10.2.4
$ export COMMITS_IN_BRANCH=$(git rev-list $CI_MERGE_REQUEST_DIFF_BASE_SHA..$CI_COMMIT_SHA | wc --lines)
$ export BACKREFERENCE_COUNT=$(($COMMITS_IN_BRANCH - 1))
$ npx commitlint --verbose --from HEAD~$BACKREFERENCE_COUNT
✖   Please add rules to your `commitlint.config.js`
    - Getting started guide: https://commitlint.js.org/#/?id=getting-started
    - Example config: https://github.com/conventional-changelog/commitlint/blob/master/%40commitlint/config-conventional/src/index.ts [empty-rules]
✖   found 1 problems, 0 warnings
ⓘ   Get help: https://github.com/conventional-changelog/commitlint/#what-is-commitlint
Cleaning up project directory and file based variables 00:00
ERROR: Job failed: exit code 1

I have a .commitlintrc.yml at the root of the repository that it normally picks up fine.

[escapedcat]

Please give this a try:
https://github.com/conventional-changelog/commitlint/releases/tag/v18.6.2

Thanks to @dargmuesli for jumping in and @masterT, @jerome-benoit and @knocte for review and feedback!

[jerome-benoit]

Please give this a try: https://github.com/conventional-changelog/commitlint/releases/tag/v18.6.2

So far, so good on all the ESM repos I use that was broken by the previous release.

Thanks.

[mlazari]

18.6.2 works for me, thank you!

[masterT]

Same here, it's working with 18.6.2, thanks! 🙂

[mdwekat]

+1