-
Notifications
You must be signed in to change notification settings - Fork 933
Proposal: use vitepress
to generate documentation site
#3905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I would recommend to use https://rspress.dev |
I quickly tried Pros
Cons
To give an idea, here are the addition and deletion on
I'm not an expert of both tools so I don't have a preference since the configuration is quite similar. @escapedcat what do you think? |
The biggest downside of vitepress(or vite actually) is the different behavior between development vs production. |
Gotcha, thanks for the info @JounQin! @escapedcat is this good for you? |
Hm, so looking at both projects it looks like that vitepress is much more popular and has a bigger community of users (i.e. "Used by 141" vs. "Used by 20.2k") and devs. I tend to chose these projects over something that is somewhat better in a certain context.
Can you elaborate? Is this relevant for commitlint? Currently we use a very old docs-system (I believe). We never cared about dev Vs. prod for docs and I don't think we will. There not urgent need to migrate to something new. So if we migrate I'd rather chose something proven which will last for the next ~5 years or so like the current one does :P Hope this makes sense. Happy for feedback. |
Due to ESM migration I think that would be great to ship it with a new documentation. In conclusion I'm more than willing to migrate to |
Oh, sorry for the confusion, I was talking about a common issue instead of commitlint specific one. I don't know if we're using some advanced features of like React/Vue components right now and in the future. Although rspress is not popular as vitepress yet, but personally rspack is a better build tool approach then vite considering the root issues I mentioned above and
But of course, for simple document usage, vitepress is also suitable. |
Cool, let's move on with vitepress then :) |
Done via #3921 |
Recently I found out that all
vite
ecosystem docs are powered byvitepress
.Here is the official site: https://vitepress.dev
Even if it is not released yet, it's on
rc
status right now, it looks pretty good looking and solid to me.Another library that relies on
vitepress
for docs ishusky
: https://typicode.github.io/husky/Some of the features that might benefit the docs are:
You can see more examples here: https://vitepress.dev/guide/markdown
docsify
doesn't offer such features by default, you have to include additional scripts.Since we are migrating to
vitest
on #3850 I think that having documentation powered by the same ecosystemcould be a good benefit.
What do you thing about it?
If you agree I'm more than willing to setup a PR!
Before proceeding I will wait merge of #3850 to avoid conflicts
The text was updated successfully, but these errors were encountered: