-
Notifications
You must be signed in to change notification settings - Fork 933
allow to require signed commits #321
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Good idea, want to help out with this? I think a We might have to extend conventional-commits-parser to include a signature field for this to work. Want to lend a hand? |
Sure, I'll give it a shot |
@KnisterPeter @marionebl Is this feature request still open? I could take a look into that if you don´t mind. |
@tomraithel This is still open and would be great. I had no time until now so: yes give it a shot 😃 |
Hmm, after taking some time to investigate, I came to the conclusion that it´s currently not possible to add that feature. Reason is, that the conventional-commits-parser currently is only able to process commit messages whereas the signature information is not part of the commit message. From my point of view there is unfortunately nothing we can do here. |
Expected Behavior
A commit should be rejected if commitlint is configured for requiring a signed commit.
Current Behavior
There is no option to require signed commits.
Affected packages
Context
I would like to have me and my contributors to require sign git commits.
There is support for this in github. And in the github project settings one could configure that signed commits are required on PRs, but if just refuses to merge a PR instead of refuse to accept a commit.
Failing more early would simplify the process.
The text was updated successfully, but these errors were encountered: