-
Notifications
You must be signed in to change notification settings - Fork 934
"subject-empty" is over-flagged #2761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
What's you configuration? |
This happens with the default configuration:
I understand the goal of the tool. My point is that it seems nonsensical to say "subject may not be empty". The commit's subject isn't empty, it's "Try out commitlint." The problem is that it doesn't have a type, which is correctly reported as an error. |
After upgrading to 13.2.x, I experience pretty same.
|
This also causes issues when trying to disable the |
See also #3045 |
This comment was marked as duplicate.
This comment was marked as duplicate.
try giving type in commit as -> git commit -m 'feat: hello world' type must be one of [build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test] [type-enum] |
Expected Behavior
Lint a comment message like "try out commitlint." Two errors are flagged:
The "subject-empty" error seems silly: the commit message has a subject, it's "try out commitlint." In my opinion, "subject-empty" should only be raised for messages like "fix:", with a type and nothing else.
Affected packages
The text was updated successfully, but these errors were encountered: