Skip to content

scope-enum always errors out with scoped package name #2406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
2 of 4 tasks
longlho opened this issue Jan 15, 2021 · 3 comments
Closed
2 of 4 tasks

scope-enum always errors out with scoped package name #2406

longlho opened this issue Jan 15, 2021 · 3 comments

Comments

@longlho
Copy link

longlho commented Jan 15, 2021

If I configure

modules.exports = {
	extends: ['@commitlint/config-angular'],
	  rules: {
	    'scope-enum': [2, 'always', ['@foo/bar']],
	  },
}

and commit with fix(@foo/bar): test it always errors out

Expected Behavior

should pass

Current Behavior

does not pass

Affected packages

  • cli
  • core
  • prompt
  • config-angular

Possible Solution

Looks like / is considered package name separator, can this be configurable?

Steps to Reproduce (for bugs)

  1. First step
  2. Second step
commitlint.config.js ```js ```

Context

Your Environment

Executable Version
commitlint --version VERSION
git --version VERSION
node --version VERSION
@escapedcat
Copy link
Member

Hi @longlho , is this a duplicate of #2108?

@longlho
Copy link
Author

longlho commented Jan 15, 2021

oh yeah looks like it is. Feel free to close

@escapedcat
Copy link
Member

Thanks, closing because it's a duplicate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants