Skip to content

Commit messages in the format "Merge branch ..." fail linting #210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ctrom opened this issue Dec 26, 2017 · 3 comments · Fixed by #214
Closed

Commit messages in the format "Merge branch ..." fail linting #210

ctrom opened this issue Dec 26, 2017 · 3 comments · Fixed by #214
Labels

Comments

@ctrom
Copy link
Contributor

ctrom commented Dec 26, 2017

Expected Behavior

If a commit message follows the format Merge branch 'Merge-Me', it should pass the linter.

Current Behavior

Messages in the above stated format do not pass the linter. This seems to be a violation of the logic here:
https://github.com/marionebl/commitlint/blob/master/@commitlint/core/src/library/is-ignored.js

Steps to Reproduce (for bugs)

echo "Merge branch 'ctrom-YarnBuild'" | commitlint
No additional configuration required.

Executable Version
commitlint --version 5.1.1
git --version 2.15.1
node --version v9.3.0
@StarWar
Copy link

StarWar commented Dec 26, 2018

It's still not resolved.

@escapedcat
Copy link
Member

⧗   input: Merge branch 'ctrom-YarnBuild'
✔   found 0 problems, 0 warnings
    (Need help? -> https://github.com/marionebl/commitlint#what-is-commitlint)

It looks like the mentioned input works fine in the current master.
Which input is failing for you @StarWar?

@xianshenglu
Copy link

For me, it's still not work too with @commitlint/[email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

5 participants