Skip to content

@commitlint/parse using outdated version of conventional-changelog-angular #2032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 of 4 tasks
MikeActually opened this issue Jul 30, 2020 · 7 comments
Closed
1 of 4 tasks
Labels
dependencies Pull requests that update a dependency file

Comments

@MikeActually
Copy link

dot-prop dependency security issue was addressed as part of PR at conventional-changelog/conventional-changelog#647

Affected packages

  • cli
  • core
  • prompt
  • config-angular

Possible Solution

update package.json

Context

Allows for prototype pollution: GHSA-ff7x-qrg7-qggm

@escapedcat
Copy link
Member

It's already merged. Next @next release will include this: #2056

@escapedcat
Copy link
Member

escapedcat commented Aug 16, 2020

Please give this a try:
yarn add -D @commitlint/config-conventional@next @commitlint/cli@next
v10.0.0 should fix this.

@escapedcat escapedcat added the dependencies Pull requests that update a dependency file label Aug 16, 2020
@jimmyandrade
Copy link

@escapedcat thank you. I'm updating right now.

@glumia
Copy link

glumia commented Aug 31, 2020

The issue persists, @commitlint/parse is still declaring conventional-changelog-angular "^5.0.0" in its package.json:

"conventional-changelog-angular": "^5.0.0",

@escapedcat
Copy link
Member

@glumia because of the ^ in ^5.0.0 it should install 5.0.11 on npm install. Maybe try a fresh install or check what your lock file says?

@glumia
Copy link

glumia commented Aug 31, 2020

Aaa you are right sorry! There must be some problem with yarn because I solved the issue just removing by hand a line in the lock file* 😅

Thanks!

*I was somehow ending up with two lines for conventional-changelog-angular@^5.x.x in the yarn.lock file, one was causing the install of version 5.0.11 and the other one of version 5.0.10 (that brought the vulnerability issue).

@escapedcat
Copy link
Member

v11.0.0 has been released as @latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Development

No branches or pull requests

4 participants