Skip to content

Commit f81f1c5

Browse files
committed
fix: align sentence-case implementation
1 parent 8d2e5b0 commit f81f1c5

File tree

3 files changed

+4
-5
lines changed

3 files changed

+4
-5
lines changed

@commitlint/cz-commitlint/src/utils/case-fn.test.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -64,10 +64,10 @@ test('should convert text correctly', () => {
6464
expect(rule('TEST_FOOBar-baz baz')).toBe('TEST_FOOBAR-BAZ BAZ');
6565

6666
rule = getCaseFn([RuleConfigSeverity.Warning, 'always', 'sentence-case']);
67-
expect(rule('TEST_FOOBar-baz baz')).toBe('Test_foobar-baz baz');
67+
expect(rule('TEST_FOOBar-baz baz')).toBe('TEST_FOOBar-baz baz');
6868

6969
rule = getCaseFn([RuleConfigSeverity.Warning, 'always', 'sentencecase']);
70-
expect(rule('TEST_FOOBar-baz baz')).toBe('Test_foobar-baz baz');
70+
expect(rule('TEST_FOOBar-baz baz')).toBe('TEST_FOOBar-baz baz');
7171

7272
rule = getCaseFn([RuleConfigSeverity.Warning, 'always', 'lower-case']);
7373
expect(rule('TEST_FOOBar-baz baz')).toBe('test_foobar-baz baz');

@commitlint/cz-commitlint/src/utils/case-fn.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -42,8 +42,7 @@ export default function getCaseFn(rule?: Rule): CaseFn {
4242
return (input: string) => input.toUpperCase();
4343
case 'sentence-case':
4444
case 'sentencecase':
45-
return (input: string) =>
46-
`${input.charAt(0).toUpperCase()}${input.substring(1).toLowerCase()}`;
45+
return (input: string) => upperFirst(input);
4746
case 'lower-case':
4847
case 'lowercase':
4948
case 'lowerCase': // Backwards compat config-angular v4

@commitlint/ensure/src/case.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ function toCase(input: string, target: TargetCaseType): string {
4343
return input.toUpperCase();
4444
case 'sentence-case':
4545
case 'sentencecase':
46-
return input.charAt(0).toUpperCase() + input.slice(1);
46+
return upperFirst(input);
4747
case 'lower-case':
4848
case 'lowercase':
4949
case 'lowerCase': // Backwards compat config-angular v4

0 commit comments

Comments
 (0)