fix(core): fall back to globally installed config if available #126

Author: marionebl

@commitlint/core/src/library/resolve-extends.js

@@ -1,5 +1,6 @@
 import path from 'path';
 import resolveFrom from 'resolve-from';
+import resolveGlobal from 'resolve-global';
 import {merge, omit} from 'lodash';
 
 // Resolve extend configs
@@ -38,12 +39,18 @@ function loadExtends(config = {}, context = {}) {
 		const ctx = merge({}, context, {cwd});
 
 		// Resolve parser preset if none was present before
-		if (!context.parserPreset && typeof c === 'object' && typeof c.parserPreset === 'string') {
+		if (
+			!context.parserPreset &&
+			typeof c === 'object' &&
+			typeof c.parserPreset === 'string'
+		) {
 			const resolvedParserPreset = resolveFrom(cwd, c.parserPreset);
 
 			const parserPreset = {
 				name: c.parserPreset,
-				path: `./${path.relative(process.cwd(), resolvedParserPreset)}`.split(path.sep).join('/'),
+				path: `./${path.relative(process.cwd(), resolvedParserPreset)}`
+					.split(path.sep)
+					.join('/'),
 				opts: require(resolvedParserPreset)
 			};
 
@@ -79,5 +86,20 @@ function resolveConfig(raw, context = {}) {
 }
 
 function resolveId(id, context = {}) {
-	return resolveFrom(context.cwd || process.cwd(), id);
+	const cwd = context.cwd || process.cwd();
+	const localPath = resolveFrom.silent(cwd, id);
+
+	if (typeof localPath === 'string') {
+		return localPath;
+	}
+
+	const globalPath = resolveGlobal.silent(id);
+
+	if (typeof globalPath === 'string') {
+		return globalPath;
+	}
+
+	const err = new Error(`Cannot find module "${id}" from "${cwd}"`);
+	err.code = 'MODULE_NOT_FOUND';
+	throw err;
 }

@commitlint/core/src/library/resolve-extends.test.js

@@ -17,7 +17,7 @@ test('returns an equivalent object as passed in', t => {
 	t.deepEqual(actual, expected);
 });
 
-test.serial.failing('falls back to global install', async t => {
+test.serial('falls back to global install', async t => {
 	const prev = process.env.NPM_PACKAGES;
 
 	const cwd = await fix.bootstrap('fixtures/global-install');
@@ -26,7 +26,13 @@ test.serial.failing('falls back to global install', async t => {
 	const npm = args => execa('npm', args, {cwd});
 
 	await sander.mkdir(cwd, 'commitlint-npm-packages');
-	await npm(['install', '--global', '@commitlint/config-angular', '--prefix', prefix]);
+	await npm([
+		'install',
+		'--global',
+		'@commitlint/config-angular',
+		'--prefix',
+		prefix
+	]);
 
 	process.env.NPM_PACKAGES = prefix;
 
@@ -41,7 +47,10 @@ test.serial('fails for missing extends', async t => {
 	const cwd = await fix.bootstrap('fixtures/missing-install');
 	const input = {extends: ['@commitlint/foo-bar']};
 
-	t.throws(() => resolveExtends(input, {cwd}), /Cannot find module "@commitlint\/foo-bar" from/);
+	t.throws(
+		() => resolveExtends(input, {cwd}),
+		/Cannot find module "@commitlint\/foo-bar" from/
+	);
 });
 
 test('uses empty prefix by default', t => {

yarn.lock

@@ -6077,6 +6077,12 @@ resolve-from@^3.0.0:
   version "3.0.0"
   resolved "https://registry.npmjs.org/resolve-from/-/resolve-from-3.0.0.tgz#b22c7af7d9d6881bc8b6e653335eebcb0a188748"
 
+resolve-global@^0.1.0:
+  version "0.1.0"
+  resolved "https://registry.npmjs.org/resolve-global/-/resolve-global-0.1.0.tgz#8fb02cfd5b7db20118e886311f15af95bd15fbd9"
+  dependencies:
+    global-dirs "^0.1.0"
+
 resolve-pathname@^2.1.0:
   version "2.2.0"
   resolved "https://registry.npmjs.org/resolve-pathname/-/resolve-pathname-2.2.0.tgz#7e9ae21ed815fd63ab189adeee64dc831eefa879"