fix: support lerna 2, 3 simultaneously

Author: marionebl

@commitlint/config-lerna-scopes/fixtures/basic/lerna.json

@@ -1,5 +1,5 @@
 {
-	"lerna": "3.0.0",
+    "lerna": "3.2.1",
 	"version": "1.0.0",
 	"packages": [
 		"packages/*"

@commitlint/config-lerna-scopes/fixtures/basic/package.json

@@ -2,6 +2,6 @@
     "name": "basic",
     "version": "1.0.0",
     "devDependencies": {
-        "lerna": "3.0.4"
+        "lerna": "3.2.1"
     }
 }

@commitlint/config-lerna-scopes/fixtures/empty/lerna.json

@@ -1,5 +1,5 @@
 {
-	"lerna": "3.0.0",
+    "lerna": "3.2.1",
 	"version": "1.0.0",
 	"packages": [
 		"packages/*"

@commitlint/config-lerna-scopes/fixtures/empty/package.json

@@ -2,6 +2,6 @@
     "name": "empty",
     "version": "1.0.0",
     "devDependencies": {
-        "lerna": "3.0.4"
+        "lerna": "3.2.1"
     }
 }

@commitlint/config-lerna-scopes/fixtures/version-mismatch/lerna.json renamed to @commitlint/config-lerna-scopes/fixtures/lerna-two/lerna.json

@@ -2,6 +2,6 @@
     "name": "version-mismatch",
     "version": "1.0.0",
     "devDependencies": {
-        "lerna": "3.0.4"
+        "lerna": "2.4.0"
     }
 }

@commitlint/config-lerna-scopes/fixtures/version-mismatch/package.json renamed to @commitlint/config-lerna-scopes/fixtures/lerna-two/package.json

@@ -1,5 +1,5 @@
 {
-	"lerna": "3.0.0",
+    "lerna": "3.2.1",
 	"version": "1.0.0",
 	"packages": [
 		"@packages/*"

@commitlint/config-lerna-scopes/fixtures/scoped/lerna.json

@@ -2,6 +2,6 @@
     "name": "scoped",
     "version": "1.0.0",
     "devDependencies": {
-        "lerna": "3.0.4"
+        "lerna": "3.2.1"
     }
 }

@commitlint/config-lerna-scopes/fixtures/scoped/package.json

@@ -1,22 +1,45 @@
+const Path = require('path');
 const importFrom = require('import-from');
+const resolvePkg = require('resolve-pkg');
+const semver = require('semver');
 
 module.exports = {
 	utils: {getPackages},
 	rules: {
-		'scope-enum': async ctx => [2, 'always', await getPackages(ctx)]
+		'scope-enum': ctx =>
+			getPackages(ctx).then(packages => [2, 'always', packages])
 	}
 };
 
-async function getPackages(context) {
-	const ctx = context || {};
-	const cwd = ctx.cwd || process.cwd();
+function getPackages(context) {
+	return Promise.resolve()
+		.then(() => {
+			const ctx = context || {};
+			const cwd = ctx.cwd || process.cwd();
+			const lernaVersion = getLernaVersion(cwd);
 
-	const Project = importFrom(cwd, '@lerna/project');
+			if (semver.lt(lernaVersion, '3.0.0')) {
+				const Repository = importFrom(cwd, 'lerna/lib/Repository');
+				const PackageUtilities = importFrom(cwd, 'lerna/lib/PackageUtilities');
 
-	const project = new Project(cwd);
-	const packages = await project.getPackages();
+				const repository = new Repository(cwd);
+				return PackageUtilities.getPackages({
+					packageConfigs: repository.packageConfigs,
+					rootPath: cwd
+				});
+			}
 
-	return packages
-		.map(pkg => pkg.name)
-		.map(name => (name.charAt(0) === '@' ? name.split('/')[1] : name));
+			const Project = importFrom(cwd, '@lerna/project');
+			const project = new Project(cwd);
+			return project.getPackages();
+		})
+		.then(packages => {
+			return packages
+				.map(pkg => pkg.name)
+				.map(name => (name.charAt(0) === '@' ? name.split('/')[1] : name));
+		});
+}
+
+function getLernaVersion(cwd) {
+	return require(Path.join(resolvePkg('lerna', {cwd}), 'package.json')).version;
 }

@commitlint/config-lerna-scopes/index.js

@@ -43,11 +43,14 @@
     "lerna": "^3.0.0"
   },
   "dependencies": {
-    "import-from": "2.1.0"
+    "import-from": "2.1.0",
+    "resolve-pkg": "^1.0.0",
+    "semver": "^5.5.1"
   },
   "devDependencies": {
     "@commitlint/test": "^7.0.0",
     "@commitlint/utils": "^7.0.0",
+    "@lerna/project": "^3.0.0",
     "ava": "0.22.0",
     "lerna": "3.1.1",
     "xo": "0.20.3"

@commitlint/config-lerna-scopes/package.json

@@ -55,23 +55,15 @@ test('returns expected value for basic lerna repository', async t => {
 	t.deepEqual(value, ['a', 'b']);
 });
 
-test.failing(
-	'throws for repository with .lerna vs .devDependencies.lerna mismatch',
-	async t => {
-		const {'scope-enum': fn} = config.rules;
-		const cwd = await npm.bootstrap('fixtures/version-mismatch');
-		try {
-			await fn({cwd});
-			t.fail();
-		} catch (err) {
-			t.pass();
-		}
-	}
-);
-
 test('returns expected value for scoped lerna repository', async t => {
 	const {'scope-enum': fn} = config.rules;
 	const cwd = await npm.bootstrap('fixtures/scoped');
 	const [, , value] = await fn({cwd});
 	t.deepEqual(value, ['a', 'b']);
 });
+
+test('works with lerna version < 3', async t => {
+	const {'scope-enum': fn} = config.rules;
+	const cwd = await npm.bootstrap('fixtures/lerna-two');
+	await t.notThrows(async () => fn({cwd}));
+});

@commitlint/config-lerna-scopes/test.js

@@ -7443,7 +7443,7 @@ resolve-pathname@^2.1.0:
   version "2.2.0"
   resolved "https://registry.npmjs.org/resolve-pathname/-/resolve-pathname-2.2.0.tgz#7e9ae21ed815fd63ab189adeee64dc831eefa879"
 
-[email protected]:
+[email protected], resolve-pkg@^1.0.0:
   version "1.0.0"
   resolved "https://registry.npmjs.org/resolve-pkg/-/resolve-pkg-1.0.0.tgz#e19a15e78aca2e124461dc92b2e3943ef93494d9"
   dependencies:
@@ -7595,6 +7595,10 @@ [email protected], semver@^5.5.0:
   version "5.5.0"
   resolved "https://registry.npmjs.org/semver/-/semver-5.5.0.tgz#dc4bbc7a6ca9d916dee5d43516f0092b58f7b8ab"
 
+semver@^5.5.1:
+  version "5.5.1"
+  resolved "https://registry.npmjs.org/semver/-/semver-5.5.1.tgz#7dfdd8814bdb7cabc7be0fb1d734cfb66c940477"
+
 semver@~5.3.0:
   version "5.3.0"
   resolved "https://registry.npmjs.org/semver/-/semver-5.3.0.tgz#9b2ce5d3de02d17c6012ad326aa6b4d0cf54f94f"