Skip to content

Commit 9254b3b

Browse files
committed
pkg/sysinfo: remove NUMANodeCount
Found a few issues in this code and went ahead to fix them one by one, only to find out this function is not used anywhere in our codebase or otherwise (see [1], [2]). Remove it. [1]: https://github.com/search?q=org%3Acontainers+NUMANodeCount&type=code [2]: https://sourcegraph.com/search?q=context%3Aglobal+sysinfo.NUMANodeCount Signed-off-by: Kir Kolyshkin <[email protected]>
1 parent dd8ab77 commit 9254b3b

File tree

3 files changed

+0
-51
lines changed

3 files changed

+0
-51
lines changed

pkg/sysinfo/nummem_linux.go

Lines changed: 0 additions & 32 deletions
This file was deleted.

pkg/sysinfo/nummem_unsupported.go

Lines changed: 0 additions & 9 deletions
This file was deleted.

pkg/sysinfo/sysinfo_linux_test.go

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -97,13 +97,3 @@ func TestNumCPU(t *testing.T) {
9797
t.Fatal("CPU returned must be greater than zero")
9898
}
9999
}
100-
101-
func TestNumMems(t *testing.T) {
102-
if _, err := os.Stat("/proc/self/numa_maps"); !errors.Is(err, os.ErrNotExist) {
103-
t.Skip("NUMA must be supported")
104-
}
105-
cpuMems := NUMANodeCount()
106-
if cpuMems < 0 {
107-
t.Fatal("Invalid number of memory nodes, must be 0 or greater.")
108-
}
109-
}

0 commit comments

Comments
 (0)