Skip to content

Commit 8f93a10

Browse files
committed
Auto merge of rust-lang#130072 - ChrisDenton:split-ci, r=Kobzol
Split x86_64-msvc-ext into two jobs This is an attempt to mitigate (but not resolve) the high failure rate of the x86_64-msvc-ext builder. The theory being that doing less makes it less likely to fail. But this may not work as having an extra job that may fail might be worse. try-job: x86_64-msvc-ext try-job: x86_64-msvc-ext2
2 parents 6d05f12 + 0d94e6b commit 8f93a10

File tree

2 files changed

+22
-5
lines changed

2 files changed

+22
-5
lines changed

Diff for: src/ci/docker/host-x86_64/x86_64-gnu-tools/checktools.sh

+10-5
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,9 @@ case $HOST_TARGET in
5858
# Strangely, Linux targets do not work here. cargo always says
5959
# "error: cannot produce cdylib for ... as the target ... does not support these crate types".
6060
# Only run "pass" tests, which is quite a bit faster.
61-
python3 "$X_PY" test --stage 2 src/tools/miri --target aarch64-apple-darwin --test-args pass
62-
python3 "$X_PY" test --stage 2 src/tools/miri --target i686-pc-windows-gnu --test-args pass
61+
#FIXME: Re-enable this once CI issues are fixed
62+
#python3 "$X_PY" test --stage 2 src/tools/miri --target aarch64-apple-darwin --test-args pass
63+
#python3 "$X_PY" test --stage 2 src/tools/miri --target i686-pc-windows-gnu --test-args pass
6364
;;
6465
*)
6566
echo "FATAL: unexpected host $HOST_TARGET"
@@ -68,6 +69,10 @@ case $HOST_TARGET in
6869
esac
6970
# Also smoke-test `x.py miri`. This doesn't run any actual tests (that would take too long),
7071
# but it ensures that the crates build properly when tested with Miri.
71-
python3 "$X_PY" miri --stage 2 library/core --test-args notest
72-
python3 "$X_PY" miri --stage 2 library/alloc --test-args notest
73-
python3 "$X_PY" miri --stage 2 library/std --test-args notest
72+
73+
#FIXME: Re-enable this for msvc once CI issues are fixed
74+
if [ "$HOST_TARGET" != "x86_64-pc-windows-msvc" ]; then
75+
python3 "$X_PY" miri --stage 2 library/core --test-args notest
76+
python3 "$X_PY" miri --stage 2 library/alloc --test-args notest
77+
python3 "$X_PY" miri --stage 2 library/std --test-args notest
78+
fi

Diff for: src/ci/github-actions/jobs.yml

+12
Original file line numberDiff line numberDiff line change
@@ -373,6 +373,18 @@ auto:
373373
DEPLOY_TOOLSTATES_JSON: toolstates-windows.json
374374
<<: *job-windows-8c
375375

376+
# Temporary builder to workaround CI issues
377+
- image: x86_64-msvc-ext2
378+
env:
379+
SCRIPT: >
380+
python x.py test --stage 2 src/tools/miri --target aarch64-apple-darwin --test-args pass &&
381+
python x.py test --stage 2 src/tools/miri --target i686-pc-windows-gnu --test-args pass &&
382+
python x.py miri --stage 2 library/core --test-args notest &&
383+
python x.py miri --stage 2 library/alloc --test-args notest &&
384+
python x.py miri --stage 2 library/std --test-args notest
385+
RUST_CONFIGURE_ARGS: --build=x86_64-pc-windows-msvc --enable-lld
386+
<<: *job-windows-8c
387+
376388
# 32/64-bit MinGW builds.
377389
#
378390
# We are using MinGW with POSIX threads since LLVM requires

0 commit comments

Comments
 (0)