Upgrade to Spring Boot 2.2.5

This is primarily motivated by an upcoming dependency on
HeaderResultMatchers::dateValue, which has a hard dependency on JUnit 4,
fixed in v5.1.8 and v5.2.4 [1]. It was either reintroduce JUnit 4 until
this inevitable upgrade, or upgrade now. We'll be in a better position
for Spring Boot 2.3, at least.

Other exciting changes include changing Freemarker view extensions from
.ftl to .ftlh [2], trivial API churn, new Flyway, and new PostgreSQL
JDBC driver.

[1] spring-projects/spring-framework@233b225
[2] spring-projects/spring-boot#15131

Author: commonquail

pom.xml

@@ -4,7 +4,7 @@
   <parent>
     <groupId>org.springframework.boot</groupId>
     <artifactId>spring-boot-starter-parent</artifactId>
-    <version>2.1.5.RELEASE</version>
+    <version>2.2.5.RELEASE</version>
     <relativePath />
   </parent>
   <groupId>io.gitlab.mkjeldsen</groupId>
@@ -78,8 +78,8 @@
       <scope>test</scope>
       <exclusions>
         <exclusion>
-          <groupId>junit</groupId>
-          <artifactId>junit</artifactId>
+          <groupId>org.junit.vintage</groupId>
+          <artifactId>junit-vintage-engine</artifactId>
         </exclusion>
       </exclusions>
     </dependency>

src/main/java/io/gitlab/mkjeldsen/prstatbucket/AppConfig.java

@@ -54,8 +54,9 @@ public Jdbi jdbi() {
         psql.setUser(env.getProperty("db.user"));
         psql.setPassword(env.getProperty("db.password"));
         psql.setDatabaseName(env.getProperty("db.database"));
-        psql.setServerName(env.getProperty("db.server"));
-        psql.setPortNumber(Integer.parseInt(env.getProperty("db.port")));
+        psql.setServerNames(new String[] {env.getProperty("db.server")});
+        psql.setPortNumbers(
+                new int[] {Integer.parseInt(env.getProperty("db.port"))});
         psql.setApplicationName("prstatbucket");
 
         final var hikariConfig = new HikariConfig();

src/main/java/io/gitlab/mkjeldsen/prstatbucket/PrstatbucketApplication.java

@@ -25,8 +25,8 @@ public void migrateDatabase(final ApplicationStartedEvent e) {
         final String database = env.getProperty("db.database");
 
         final var psql = new PGSimpleDataSource();
-        psql.setServerName(server);
-        psql.setPortNumber(port);
+        psql.setServerNames(new String[] {server});
+        psql.setPortNumbers(new int[] {port});
         psql.setDatabaseName(database);
         psql.setUser(user);
         psql.setPassword(password);

src/main/java/io/gitlab/mkjeldsen/prstatbucket/unresolved/UnresolvedReviewController.java

@@ -40,7 +40,7 @@ public ModelAndView asHtml() {
 
     @GetMapping(
             value = "/unresolved",
-            consumes = MediaType.APPLICATION_JSON_UTF8_VALUE)
+            consumes = MediaType.APPLICATION_JSON_VALUE)
     @ResponseBody
     public ResponseEntity<List<UnresolvedReview>> asJson() {
         final var pullRequests = unresolvedReviewService.getOpenPullRequests();

src/main/resources/templates/unresolved-review.ftl renamed to src/main/resources/templates/unresolved-review.ftlh

@@ -95,7 +95,7 @@ void serves_json_on_request() throws Exception {
                 .thenReturn(someData);
 
         final var requestJson =
-                get("/unresolved").contentType(MediaType.APPLICATION_JSON_UTF8);
+                get("/unresolved").contentType(MediaType.APPLICATION_JSON);
         final var matchingJsonBody =
                 content().json(read("/unresolved-review.json"));
         final var matchingMediaType =