Skip to content

Bug, subject converted to lowercase #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
unlight opened this issue Sep 25, 2019 · 4 comments
Closed

Bug, subject converted to lowercase #97

unlight opened this issue Sep 25, 2019 · 4 comments

Comments

@unlight
Copy link

unlight commented Sep 25, 2019

Function filterSubject converts all inputs to lower case.
I want to keep my subject sentence cased.

@bjoluc
Copy link

bjoluc commented Apr 22, 2020

This is what happens:

var filterSubject = function(subject) {
subject = subject.trim();
if (subject.charAt(0).toLowerCase() !== subject.charAt(0)) {
subject =
subject.charAt(0).toLowerCase() + subject.slice(1, subject.length);
}
while (subject.endsWith('.')) {
subject = subject.slice(0, subject.length - 1);
}
return subject;
};

I'd like to keep my first letter uppercase as well – @jimthedev I'm failing to find a spec for this. Am I missing something? If not, would you accept a PR to remove the modification of the first letter? Thanks in advance!

@unlight
Copy link
Author

unlight commented Apr 22, 2020

@chrisgarber
Copy link

I believe this is fixed by the config option disableSubjectLowerCase

@bjoluc
Copy link

bjoluc commented Jul 9, 2021

Absolutely, thanks @chrisgarber! @unlight Would you mind closing the issue?

@unlight unlight closed this as completed Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants