Skip to content

Rename improvement to improv or similar #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
NathanUrwin opened this issue Oct 30, 2019 · 2 comments
Closed

Rename improvement to improv or similar #15

NathanUrwin opened this issue Oct 30, 2019 · 2 comments

Comments

@NathanUrwin
Copy link

Improvement is kind of long... we're truncating feature to feat, so why not improvement to improv?
@AndersDJohnson
Copy link
Member

@NathanUrwin I totally agree with you, but it's what is suggested on the official Conventional Commits spec now, so many people and teams are using it, so we're trying to align with that. I would encourage and support a proposal to have them change the spec though.

@AndersDJohnson AndersDJohnson mentioned this issue Nov 3, 2019
Merged
@AndersDJohnson
Copy link
Member

@NathanUrwin It looks like they removed improvement as recommended. It was in their 1.0.0-beta.4 release, but removed in 1.0.0.

I'm proposing we consider removing it in #16, so I would appreciate if you could share thoughts there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AndersDJohnson @NathanUrwin