Skip to content

Found AOT issues and resolved one. Another needs more work #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

micahriggan
Copy link

Need to experiment with RewireRoutes to determine why it can't be resolved statically.

Could be due to the use of the window object, or using keys of objects without type definitions

Maybe building a type definition for what window will look like here

window['dynamicRouteMappings'][paths[ind]]

@colinjlacy
Copy link
Owner

Pulling down this PR, I can get it to build as is. But even if I add something as simple as a console.log before return routes;it throws the same static analysis error. So I don't think it's the internal workings of the RewireRoutes method calling window or referencing a map with string keys is necessarily the issue. It's odd though that even adding the slightest functionality causes it to fall apart. I'm back to feeling like I'm missing something.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants