Skip to content

Commit 908e03c

Browse files
codymikolcodymikol
authored
Revert "chore: fix maintainers images being squished (#576)" (#577)
This reverts commit 701a082.
1 parent 701a082 commit 908e03c

File tree

1 file changed

+50
-71
lines changed

1 file changed

+50
-71
lines changed

‎README.md

+50-71
Original file line numberDiff line numberDiff line change
@@ -24,15 +24,14 @@ yarn `yarn add -D karma-webpack`
2424
<h2 align="center">Usage</h2>
2525

2626
**karma.conf.js**
27-
2827
```js
2928
module.exports = (config) => {
3029
config.set({
3130
// ... normal karma configuration
3231

3332
// make sure to include webpack as a framework
3433
frameworks: ['mocha', 'webpack'],
35-
34+
3635
plugins: [
3736
'karma-webpack',
3837
'karma-mocha',
@@ -41,12 +40,12 @@ module.exports = (config) => {
4140
files: [
4241
// all files ending in ".test.js"
4342
// !!! use watched: false as we use webpacks watch
44-
{pattern: 'test/**/*.test.js', watched: false}
43+
{ pattern: 'test/**/*.test.js', watched: false }
4544
],
4645

4746
preprocessors: {
4847
// add webpack as preprocessor
49-
'test/**/*.test.js': ['webpack']
48+
'test/**/*.test.js': [ 'webpack' ]
5049
},
5150

5251
webpack: {
@@ -96,30 +95,25 @@ const defaultWebpackOptions = {
9695

9796
### How it works
9897

99-
This project is a framework and preprocessor for Karma that combines test files and dependencies into 2 shared bundles
100-
and 1 chunk per test file. It relies on webpack to generate the bundles/chunks and to keep it updated during
101-
autoWatch=true.
98+
This project is a framework and preprocessor for Karma that combines test files and dependencies into 2 shared bundles and 1 chunk per test file. It relies on webpack to generate the bundles/chunks and to keep it updated during autoWatch=true.
10299

103-
The first preproccessor triggers the build of all the bundles/chunks and all following files just return the output of
104-
this one build process.
100+
The first preproccessor triggers the build of all the bundles/chunks and all following files just return the output of this one build process.
105101

106102
### Webpack typescript support
107103

108-
By default karma-webpack forces *.js files so if you test *.ts files and use webpack to build typescript to javascript
109-
it works out of the box.
104+
By default karma-webpack forces *.js files so if you test *.ts files and use webpack to build typescript to javascript it works out of the box.
110105

111106
If you have a different need you can override by settig `webpack.transformPath`
112107

113108
```js
114109
// this is the by default applied transformPath
115110
webpack: {
116111
transformPath: (filepath) => {
117-
// force *.js files by default
118-
const info = path.parse(filepath);
119-
return `${path.join(info.dir, info.name)}.js`;
120-
},
121-
}
122-
,
112+
// force *.js files by default
113+
const info = path.parse(filepath);
114+
return `${path.join(info.dir, info.name)}.js`;
115+
},
116+
},
123117
```
124118

125119
### `Source Maps`
@@ -133,113 +127,98 @@ npm i -D karma-sourcemap-loader
133127
And then add it to your preprocessors.
134128

135129
**karma.conf.js**
136-
137130
```js
138131
preprocessors: {
139-
'test/test_index.js'
140-
:
141-
['webpack', 'sourcemap']
132+
'test/test_index.js': [ 'webpack', 'sourcemap' ]
142133
}
143134
```
144135

145136
And tell `webpack` to generate sourcemaps.
146137

147138
**webpack.config.js**
148-
149139
```js
150140
webpack: {
151141
// ...
152142
devtool: 'inline-source-map'
153143
}
154144
```
155145

156-
<style>
157-
158-
.maintainer-container {
159-
display: flex;
160-
flex-direction: row;
161-
flex-wrap: wrap;
162-
}
163-
164-
.maintainer {
165-
display: flex;
166-
flex-direction: column;
167-
padding: 8px;
168-
}
169-
170-
.maintainer > a {
171-
padding-top: 8px;
172-
}
173-
174-
</style>
175-
176146
<h2 align="center">Current Maintainers</h2>
177147

178-
<div class="maintainer-container">
179-
<div class="maintainer">
180-
<img width="150" height="150" src="https://avatars.githubusercontent.com/u/13606342?s=460&u=467cf9a106d2bb474cf627ffd4e0eac80d0b4705&v=4">
181-
<a href="http://codymikol.com">Cody Mikol</a>
182-
</div>
183-
</div>
184-
148+
<table>
149+
<tbody>
150+
<tr>
151+
<td>
152+
<img width="150" height="150"
153+
src="https://avatars.githubusercontent.com/u/13606342?s=460&u=467cf9a106d2bb474cf627ffd4e0eac80d0b4705&v=4">
154+
<br>
155+
<a href="http://codymikol.com">Cody Mikol</a>
156+
</td>
157+
</tr>
158+
<tbody>
159+
</table>
185160

186161
<h2 align="center">Previous Maintainers</h2>
187162

188-
Previous maintainers of the `karma-webpack` plugin that have done such amazing work to get it to where it is today. 🎉🎉🎉
163+
Previous maintainers of the `karma-webpack` plugin that have done such amazing work to get it to where it is today.
189164

190-
<div class="maintainer-container">
191-
<div class="maintainer">
165+
<table class="maintainers">
166+
<tbody>
167+
<tr>
168+
<td align="center">
192169
<img width="150" height="150"
193170
src="https://avatars0.githubusercontent.com/u/7922109?v=4&s=150">
171+
<br>
194172
<a href="https://github.com/ryanclark">Ryan Clark</a>
195-
</div>
196-
<div class="maintainer">
173+
</td>
174+
<td align="center">
197175
<img width="150" height="150"
198176
src="https://avatars3.githubusercontent.com/u/2045543?v=4&s=150">
177+
<br>
199178
<a href="https://github.com/AprilArcus">April Arcus</a>
200-
</div>
201-
<div class="maintainer">
179+
</td>
180+
<td align="center">
202181
<img width="150" height="150"
203182
src="https://avatars.githubusercontent.com/u/4650931?v=3&s=150">
183+
</br>
204184
<a href="https://github.com/MikaAK">Mika Kalathil</a>
205-
</div>
206-
<div class="maintainer">
185+
</td>
186+
<td align="center">
207187
<img width="150" height="150"
208188
src="https://avatars.githubusercontent.com/u/8420490?v=3&s=150">
209189
<a href="https://github.com/d3viant0ne">Joshua Wiens</a>
210-
</div>
211-
<div class="maintainer">
190+
</td>
191+
<td align="center">
212192
<img width="150" height="150" src="https://avatars.githubusercontent.com/u/1919664?v=3&s=150">
213193
<a href="https://github.com/goldhand">Will Farley</a>
214-
</div>
215-
<div class="maintainer">
194+
</td>
195+
<td align="center">
216196
<img width="150" height="150"
217197
src="https://avatars.githubusercontent.com/u/1307954?v=3&s=150">
218198
<a href="https://github.com/DanielaValero">Daniela Valero</a>
219-
</div>
199+
</td>
220200
</tr>
221201
<tr>
222-
<div class="maintainer">
202+
<td align="center">
223203
<img width="150" height="150"
224204
src="https://avatars.githubusercontent.com/u/122108?v=3&s=150">
225205
<a href="https://github.com/jon301">Jonathan Trang</a>
226-
</div>
227-
<div class="maintainer">
206+
</td>
207+
<td align="center">
228208
<img width="150" height="150"
229209
src="https://avatars.githubusercontent.com/u/3285723?v=3&s=150">
230210
<a href="https://github.com/carlos-">Carlos Morales</a>
231-
</div>
232-
</div>
211+
</td>
212+
</tr>
213+
<tbody>
214+
</table>
233215

234216

235217
[npm]: https://img.shields.io/npm/v/karma-webpack.svg
236-
237218
[npm-url]: https://npmjs.com/package/karma-webpack
238219

239220
[node]: https://img.shields.io/node/v/karma-webpack.svg
240-
241221
[node-url]: https://nodejs.org
242222

243223
[cover]: https://codecov.io/gh/webpack-contrib/karma-webpack/branch/master/graph/badge.svg
244-
245224
[cover-url]: https://codecov.io/gh/webpack-contrib/karma-webpack

0 commit comments

Comments
 (0)