Skip to content

Commit aaf310e

Browse files
authored
Cleaned up todos and some comments (#44)
1 parent ec52ac0 commit aaf310e

File tree

5 files changed

+4
-7
lines changed

5 files changed

+4
-7
lines changed

catalog/ui/catalog-ui-search/src/main/java/org/codice/ddf/catalog/ui/metacard/MetacardApplication.java

-1
Original file line numberDiff line numberDiff line change
@@ -231,7 +231,6 @@ public void init() {
231231
return util.getJson(validator.validateAttribute(attribute, value));
232232
});
233233

234-
// TODO (RCZ) - this could use some help
235234
get("/history/:id", (req, res) -> {
236235
String id = req.params(":id");
237236
List<Result> queryResponse = getMetacardHistory(id);

catalog/ui/catalog-ui-search/src/main/java/org/codice/ddf/catalog/ui/metacard/enumerations/ExperimentalEnumerationExtractor.java

+3-2
Original file line numberDiff line numberDiff line change
@@ -31,9 +31,10 @@
3131
import ddf.catalog.data.impl.BasicTypes;
3232
import ddf.catalog.validation.AttributeValidatorRegistry;
3333
import ddf.catalog.validation.violation.ValidationViolation;
34-
import spark.Experimental;
3534

36-
@Experimental // TODO (RCZ) - This is sparks experimental iface, could we use?
35+
/**
36+
* This class is Experimental and subject to change
37+
*/
3738
public class ExperimentalEnumerationExtractor {
3839
private final AttributeValidatorRegistry attributeValidatorRegistry;
3940

catalog/ui/catalog-ui-search/src/main/java/org/codice/ddf/catalog/ui/metacard/workspace/WorkspaceTransformer.java

-1
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,6 @@ public Metacard toMetacardFromXml(Serializable xml) {
194194
}
195195
}
196196
} catch (Exception ex) {
197-
// TODO (RCZ) - just throw?
198197
throw new RuntimeException(ex);
199198
}
200199

catalog/ui/catalog-ui-search/src/main/java/org/codice/ddf/catalog/ui/searchui/standard/endpoints/MetacardEditEndpoint.java

+1-1
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,7 @@ public Response deleteAttribute(@Context HttpServletResponse response,
196196

197197
if (metacardAttribute == null) {
198198
return Response.ok()
199-
.build(); // TODO (RCZ) - if it wasn't there is that an okay or bad?
199+
.build();
200200
}
201201

202202

catalog/ui/catalog-ui-search/src/main/java/org/codice/ddf/catalog/ui/util/EndpointUtil.java

-2
Original file line numberDiff line numberDiff line change
@@ -187,7 +187,6 @@ public Map<String, Result> getMetacards(String attributeName, Collection<String>
187187
return results;
188188
}
189189

190-
// TODO (RCZ) - This method could do with some immutable/persistant objects
191190
@SuppressWarnings("unchecked")
192191
public Map<String, Object> getMetacardTypeMap() {
193192
Map<String, Object> resultTypes = new HashMap<>();
@@ -261,7 +260,6 @@ public Map<String, Object> transformToMap(List<Metacard> metacards) {
261260
typeMap.put("type-name", type);
262261
typeMap.put("type", getMetacardTypeMap().get(type));
263262

264-
// TODO (RCZ) - optimize this since might be hit a lot
265263
typeMap.put("ids",
266264
metacards.stream()
267265
.filter(mc -> type.equals(mc.getMetacardType()

0 commit comments

Comments
 (0)