Skip to content

Commit 64104b3

Browse files
committed
Disable panel header menu
1 parent 18df68d commit 64104b3

File tree

2 files changed

+12
-7
lines changed

2 files changed

+12
-7
lines changed

public/app/features/dashboard/dashgrid/PanelHeader/PanelHeader.tsx

+5-6
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
import { css, cx } from '@emotion/css';
2+
import { Box } from '@mui/material';
23
import React from 'react';
34

45
import { DataLink, GrafanaTheme2, PanelData } from '@grafana/data';
@@ -12,7 +13,6 @@ import { getPanelLinksSupplier } from 'app/features/panel/panellinks/linkSupplie
1213
import PanelHeaderCorner from './PanelHeaderCorner';
1314
import { PanelHeaderLoadingIndicator } from './PanelHeaderLoadingIndicator';
1415
import { PanelHeaderMenuTrigger } from './PanelHeaderMenuTrigger';
15-
import { PanelHeaderMenuWrapper } from './PanelHeaderMenuWrapper';
1616
import { PanelHeaderNotices } from './PanelHeaderNotices';
1717

1818
export interface Props {
@@ -49,7 +49,7 @@ export function PanelHeader({ panel, error, isViewing, isEditing, data, alertSta
4949
links={getPanelLinksSupplier(panel)}
5050
error={error}
5151
/>
52-
<div className={className}>
52+
<Box className={className} sx={{ '&:hover': { backgroundColor: 'transparent !important' } }}>
5353
<PanelHeaderMenuTrigger data-testid={selectors.components.Panels.Panel.title(title)} onOpenMenu={onOpenMenu}>
5454
{({ closeMenu, panelMenuOpen }) => {
5555
return (
@@ -67,8 +67,8 @@ export function PanelHeader({ panel, error, isViewing, isEditing, data, alertSta
6767
<h2 className={styles.titleText}>{title}</h2>
6868
{!dashboard.meta.publicDashboardAccessToken && (
6969
<div data-testid="panel-dropdown">
70-
<Icon name="angle-down" className="panel-menu-toggle" />
71-
{panelMenuOpen ? <PanelHeaderMenuWrapper panel={panel} dashboard={dashboard} /> : null}
70+
{/* <Icon name="angle-down" className="panel-menu-toggle" />
71+
{panelMenuOpen ? <PanelHeaderMenuWrapper panel={panel} dashboard={dashboard} /> : null} */}
7272
</div>
7373
)}
7474
{data.request && data.request.timeInfo && (
@@ -81,7 +81,7 @@ export function PanelHeader({ panel, error, isViewing, isEditing, data, alertSta
8181
);
8282
}}
8383
</PanelHeaderMenuTrigger>
84-
</div>
84+
</Box>
8585
</>
8686
);
8787
}
@@ -93,7 +93,6 @@ const panelStyles = (theme: GrafanaTheme2) => {
9393
overflow: hidden;
9494
white-space: nowrap;
9595
max-width: calc(100% - 38px);
96-
cursor: pointer;
9796
font-weight: ${theme.typography.fontWeightMedium};
9897
font-size: ${theme.typography.body.fontSize};
9998
margin: 0;

public/app/features/dashboard/dashgrid/PanelHeader/PanelHeaderMenuTrigger.tsx

+7-1
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,13 @@ export function PanelHeaderMenuTrigger({ children, onOpenMenu, ...divProps }: Pr
3737
return (
3838
// TODO: fix keyboard a11y
3939
// eslint-disable-next-line jsx-a11y/click-events-have-key-events, jsx-a11y/no-static-element-interactions
40-
<header {...divProps} className="panel-title-container" onClick={onMenuToggle} onMouseDown={onMouseDown}>
40+
<header
41+
{...divProps}
42+
className="panel-title-container"
43+
onClick={onMenuToggle}
44+
onMouseDown={onMouseDown}
45+
style={{ cursor: 'unset' }}
46+
>
4147
{children({ panelMenuOpen, closeMenu: () => setPanelMenuOpen(false) })}
4248
</header>
4349
);

0 commit comments

Comments
 (0)