From 07271f04425ebbda8d0843db059dd9844d39dafb Mon Sep 17 00:00:00 2001 From: Hyunggyu Jang Date: Thu, 10 Aug 2023 00:09:15 +0900 Subject: [PATCH] Fix tokens calculation & cleanup the file summary prompt logic --- src/review.ts | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/src/review.ts b/src/review.ts index 862f386c..f5bee752 100644 --- a/src/review.ts +++ b/src/review.ts @@ -320,26 +320,22 @@ ${ } ins.filename = filename + ins.fileDiff = fileDiff // render prompt based on inputs so far - let tokens = getTokenCount( - prompts.renderSummarizeFileDiff(ins, options.reviewSimpleChanges) - ) + const summarizePrompt = prompts.renderSummarizeFileDiff(ins, options.reviewSimpleChanges) + let tokens = getTokenCount(summarizePrompt) - const diffTokens = getTokenCount(fileDiff) - if (tokens + diffTokens > options.lightTokenLimits.requestTokens) { + if (tokens > options.lightTokenLimits.requestTokens) { info(`summarize: diff tokens exceeds limit, skip ${filename}`) summariesFailed.push(`${filename} (diff tokens exceeds limit)`) return null } - ins.fileDiff = fileDiff - tokens += fileDiff.length - // summarize content try { const [summarizeResp] = await lightBot.chat( - prompts.renderSummarizeFileDiff(ins, options.reviewSimpleChanges), + summarizePrompt, {} )