submit empty review when there are no comments (#393)

Author: harjotgill

dist/index.js

@@ -232,7 +232,28 @@ ${COMMENT_TAG}`
   }
 
   async submitReview(pullNumber: number, commitId: string, statusMsg: string) {
+    const body = `${COMMENT_GREETING}
+
+${statusMsg}
+`
+
     if (this.reviewCommentsBuffer.length === 0) {
+      // Submit empty review with statusMsg
+      info(`Submitting empty review for PR #${pullNumber}`)
+      try {
+        await octokit.pulls.createReview({
+          owner: repo.owner,
+          repo: repo.repo,
+          // eslint-disable-next-line camelcase
+          pull_number: pullNumber,
+          // eslint-disable-next-line camelcase
+          commit_id: commitId,
+          event: 'COMMENT',
+          body
+        })
+      } catch (e) {
+        warning(`Failed to submit empty review: ${e}`)
+      }
       return
     }
     for (const comment of this.reviewCommentsBuffer) {
@@ -297,11 +318,6 @@ ${COMMENT_TAG}`
         `Submitting review for PR #${pullNumber}, total comments: ${this.reviewCommentsBuffer.length}, review id: ${review.data.id}`
       )
 
-      const body = `${COMMENT_GREETING}
-
-${statusMsg}
-`
-
       await octokit.pulls.submitReview({
         owner: repo.owner,
         repo: repo.repo,

src/commenter.ts

@@ -619,51 +619,55 @@ ${commentChain}
 `
       }
 
-      // perform review
-      try {
-        const [response] = await heavyBot.chat(
-          prompts.renderReviewFileDiff(ins),
-          {}
-        )
-        if (response === '') {
-          info('review: nothing obtained from openai')
-          reviewsFailed.push(`${filename} (no response)`)
-          return
-        }
-        // parse review
-        const reviews = parseReview(response, patches, options.debug)
-        for (const review of reviews) {
-          // check for LGTM
-          if (
-            !options.reviewCommentLGTM &&
-            (review.comment.includes('LGTM') ||
-              review.comment.includes('looks good to me'))
-          ) {
-            continue
-          }
-          if (context.payload.pull_request == null) {
-            warning('No pull request found, skipping.')
-            continue
+      if (patchesPacked > 0) {
+        // perform review
+        try {
+          const [response] = await heavyBot.chat(
+            prompts.renderReviewFileDiff(ins),
+            {}
+          )
+          if (response === '') {
+            info('review: nothing obtained from openai')
+            reviewsFailed.push(`${filename} (no response)`)
+            return
           }
+          // parse review
+          const reviews = parseReview(response, patches, options.debug)
+          for (const review of reviews) {
+            // check for LGTM
+            if (
+              !options.reviewCommentLGTM &&
+              (review.comment.includes('LGTM') ||
+                review.comment.includes('looks good to me'))
+            ) {
+              continue
+            }
+            if (context.payload.pull_request == null) {
+              warning('No pull request found, skipping.')
+              continue
+            }
 
-          try {
-            await commenter.bufferReviewComment(
-              filename,
-              review.startLine,
-              review.endLine,
-              `${review.comment}`
-            )
-          } catch (e: any) {
-            reviewsFailed.push(`${filename} comment failed (${e as string})`)
+            try {
+              await commenter.bufferReviewComment(
+                filename,
+                review.startLine,
+                review.endLine,
+                `${review.comment}`
+              )
+            } catch (e: any) {
+              reviewsFailed.push(`${filename} comment failed (${e as string})`)
+            }
           }
+        } catch (e: any) {
+          warning(
+            `Failed to review: ${e as string}, skipping. backtrace: ${
+              e.stack as string
+            }`
+          )
+          reviewsFailed.push(`${filename} (${e as string})`)
         }
-      } catch (e: any) {
-        warning(
-          `Failed to review: ${e as string}, skipping. backtrace: ${
-            e.stack as string
-          }`
-        )
-        reviewsFailed.push(`${filename} (${e as string})`)
+      } else {
+        reviewsSkipped.push(`${filename} (diff too large)`)
       }
     }