Skip to content
This repository was archived by the owner on Mar 6, 2024. It is now read-only.

Commit 1ad7668

Browse files
authored
Max files (#84)
<!-- This is an auto-generated comment: release notes by openai --> ### Summary by OpenAI Chore: Limit the number of files summarized and reviewed based on configurable options. Default values for these options have been changed to 40 and 0 respectively. <!-- end of auto-generated comment: release notes by openai -->
1 parent 009542a commit 1ad7668

File tree

4 files changed

+17
-15
lines changed

4 files changed

+17
-15
lines changed

action.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,11 @@ inputs:
1313
required: false
1414
description:
1515
'Max files to summarize. Less than or equal to 0 means no limit.'
16-
default: '60'
16+
default: '40'
1717
max_files_to_review:
1818
required: false
1919
description: 'Max files to review. Less than or equal to 0 means no limit.'
20-
default: '180'
20+
default: '0'
2121
review_comment_lgtm:
2222
required: false
2323
description: 'Leave comments even if the patch is LGTM'

dist/index.js

Lines changed: 5 additions & 6 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

src/options.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -207,8 +207,8 @@ export class Options {
207207

208208
constructor(
209209
debug: boolean,
210-
max_files_to_summarize = '60',
211-
max_files_to_review = '180',
210+
max_files_to_summarize = '40',
211+
max_files_to_review = '0',
212212
review_comment_lgtm = false,
213213
path_filters: string[] | null = null,
214214
system_message = '',

src/review.ts

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,10 @@ export const codeReview = async (
185185
const summaryPromises = []
186186
const skipped_files_to_summarize = []
187187
for (const [filename, file_content, file_diff] of files_to_review) {
188-
if (summaryPromises.length < options.max_files_to_summarize) {
188+
if (
189+
options.max_files_to_summarize <= 0 ||
190+
summaryPromises.length < options.max_files_to_summarize
191+
) {
189192
summaryPromises.push(
190193
openai_concurrency_limit(async () =>
191194
generateSummary(filename, file_content, file_diff)
@@ -403,9 +406,6 @@ ${
403406
}
404407

405408
// Use Promise.all to run file review processes in parallel
406-
// rewrite this to take max_files_to_review limit into account
407-
// const reviewPromises = files_to_review.map(
408-
// async ([filename, file_content, file_diff, patches]) =>
409409
// openai_concurrency_limit(async () =>
410410
// review(filename, file_content, file_diff, patches)
411411
// )
@@ -418,7 +418,10 @@ ${
418418
file_diff,
419419
patches
420420
] of files_to_review) {
421-
if (reviewPromises.length < options.max_files_to_review) {
421+
if (
422+
options.max_files_to_review <= 0 ||
423+
reviewPromises.length < options.max_files_to_review
424+
) {
422425
reviewPromises.push(
423426
openai_concurrency_limit(async () =>
424427
review(filename, file_content, file_diff, patches)

0 commit comments

Comments
 (0)