Skip to content

Commit 7b41eed

Browse files
authored
KAFKA-17909 Remove zkBroker from ConsumerGroupHeartbeatRequest and ConsumerGroupDescribeRequest (apache#17665)
Reviewers: Chia-Ping Tsai <[email protected]>
1 parent 0799715 commit 7b41eed

File tree

3 files changed

+6
-4
lines changed

3 files changed

+6
-4
lines changed

clients/src/main/resources/common/message/ConsumerGroupDescribeRequest.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
{
1717
"apiKey": 69,
1818
"type": "request",
19-
"listeners": ["zkBroker", "broker"],
19+
"listeners": ["broker"],
2020
"name": "ConsumerGroupDescribeRequest",
2121
"validVersions": "0",
2222
"flexibleVersions": "0+",

clients/src/main/resources/common/message/ConsumerGroupHeartbeatRequest.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
{
1717
"apiKey": 68,
1818
"type": "request",
19-
"listeners": ["zkBroker", "broker"],
19+
"listeners": ["broker"],
2020
"name": "ConsumerGroupHeartbeatRequest",
2121
// Version 1 adds SubscribedTopicRegex (KIP-848), and requires the consumer to generate their own Member ID (KIP-1082)
2222
"validVersions": "0-1",

core/src/test/scala/unit/kafka/server/KafkaApisTest.scala

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11107,7 +11107,8 @@ class KafkaApisTest extends Logging {
1110711107
val consumerGroupHeartbeatRequest = new ConsumerGroupHeartbeatRequestData().setGroupId("group")
1110811108

1110911109
val requestChannelRequest = buildRequest(new ConsumerGroupHeartbeatRequest.Builder(consumerGroupHeartbeatRequest, true).build())
11110-
kafkaApis = createKafkaApis()
11110+
metadataCache = MetadataCache.kRaftMetadataCache(brokerId, () => KRaftVersion.KRAFT_VERSION_1)
11111+
kafkaApis = createKafkaApis(raftSupport = true)
1111111112
kafkaApis.handle(requestChannelRequest, RequestLocal.noCaching)
1111211113

1111311114
val expectedHeartbeatResponse = new ConsumerGroupHeartbeatResponseData()
@@ -11249,7 +11250,8 @@ class KafkaApisTest extends Logging {
1124911250
val expectedDescribedGroup = new DescribedGroup().setGroupId(groupId).setErrorCode(errorCode)
1125011251
val expectedResponse = new ConsumerGroupDescribeResponseData()
1125111252
expectedResponse.groups.add(expectedDescribedGroup)
11252-
kafkaApis = createKafkaApis()
11253+
metadataCache = MetadataCache.kRaftMetadataCache(brokerId, () => KRaftVersion.KRAFT_VERSION_1)
11254+
kafkaApis = createKafkaApis(raftSupport = true)
1125311255
kafkaApis.handle(requestChannelRequest, RequestLocal.noCaching)
1125411256
val response = verifyNoThrottling[ConsumerGroupDescribeResponse](requestChannelRequest)
1125511257

0 commit comments

Comments
 (0)