GP-2987: Fixing a few launch issues (NationalSecurityAgency#4872, Closes NationalSecurityAgency#4893)

Author: ryanmkurtz

Ghidra/RuntimeScripts/Linux/support/launch.sh

@@ -145,7 +145,7 @@ fi
 JAVA_CMD="${JAVA_HOME}/bin/java"
 
 # Get the configurable VM arguments from the launch properties
-while IFS= read -r line; do
+while IFS=$'\r\n' read -r line; do
 	VMARGS_FROM_LAUNCH_PROPS+=("$line")
 done < <(java -cp "${LS_CPATH}" LaunchSupport "${INSTALL_DIR}" -vmargs)
 

Ghidra/RuntimeScripts/Windows/support/launch.bat

@@ -129,7 +129,7 @@ if "%JAVA_HOME%" == "" (
 set "JAVA_CMD=%JAVA_HOME%\bin\java"
 
 :: Get the configurable VM arguments from the launch properties
-for /f "delims=*" %%i in ('java -cp "%LS_CPATH%" LaunchSupport "%INSTALL_DIR%" -vmargs') do set VMARG_LIST=%VMARG_LIST% %%i
+for /f "delims=*" %%i in ('java -cp "%LS_CPATH%" LaunchSupport "%INSTALL_DIR%" -vmargs') do set VMARG_LIST=!VMARG_LIST! %%i
 
 :: Set Max Heap Size if specified
 if not "%MAXMEM%"=="" (

GhidraBuild/LaunchSupport/src/main/java/LaunchSupport.java

@@ -291,7 +291,8 @@ private static int handleVmArgs(JavaConfig javaConfig) {
 			return EXIT_FAILURE;
 		}
 
-		javaConfig.getLaunchProperties().getVmArgList().forEach(arg -> System.out.println(arg));
+		// Force newline style to make cross-platform parsing consistent
+		javaConfig.getLaunchProperties().getVmArgList().forEach(e -> System.out.print(e + "\r\n"));
 		return EXIT_SUCCESS;
 	}
 }