GT-3261: Fixing possible IllegalArgumentException in sort comparator.

Integer subtraction could result in overflow.

Author: ryanmkurtz

Ghidra/Features/Base/src/main/java/ghidra/app/util/bin/format/macho/commands/SymbolTableCommand.java

@@ -84,9 +84,11 @@ private void initSymbolTableCommand(FactoryBundledWithBinaryReader reader, MachH
 			nlistList.add(NList.createNList(reader, is32bit));
 		}
 		// sort the entries by the index in the string table, so don't jump around reading
-		List<NList> sortedList = nlistList.stream().sorted(
-			(o1, o2) -> o1.getStringTableIndex() - o2.getStringTableIndex()).collect(
-				Collectors.toList());
+		List<NList> sortedList = nlistList
+				.stream()
+				.sorted((o1, o2) -> Integer.valueOf(o1.getStringTableIndex())
+						.compareTo(Integer.valueOf(o2.getStringTableIndex())))
+				.collect(Collectors.toList());
 
 		// initialize the NList strings from string table
 		long stringTableOffset = stroff;

Ghidra/Features/Base/src/main/java/ghidra/app/util/bin/format/macho/dyld/DyldCacheLocalSymbolsInfo.java

@@ -159,9 +159,11 @@ private void parseNList(MessageLog log, TaskMonitor monitor) throws CancelledExc
 				monitor.incrementProgress(1);
 			}
 			// sort the entries by the index in the string table, so don't jump around reading
-			List<NList> sortedList = nlistList.stream().sorted(
-				(o1, o2) -> o1.getStringTableIndex() - o2.getStringTableIndex()).collect(
-					Collectors.toList());
+			List<NList> sortedList = nlistList
+					.stream()
+					.sorted((o1, o2) -> Integer.valueOf(o1.getStringTableIndex())
+							.compareTo(Integer.valueOf(o2.getStringTableIndex())))
+					.collect(Collectors.toList());
 
 			// initialize the NList strings from string table
 			long stringTableOffset = startIndex + stringsOffset;