GT-3460: Fixing potential divide-by-zero

ryanmkurtz · ryanmkurtz · commit 67670576631d · 2020-01-16T08:14:37.000-05:00
diff --git a/Ghidra/Framework/Generic/src/main/java/ghidra/util/NumericUtilities.java b/Ghidra/Framework/Generic/src/main/java/ghidra/util/NumericUtilities.java
@@ -250,7 +250,7 @@ public final static long bigIntegerToUnsignedLong(BigInteger value) {
 	 * @return aligned value
 	 */
 	public static long getUnsignedAlignedValue(long unsignedValue, long alignment) {
-		if (unsignedValue % alignment == 0) {
+		if (alignment == 0 || unsignedValue % alignment == 0) {
 			return unsignedValue;
 		}
 		boolean negative = unsignedValue < 0;

Original file line number	Diff line number	Diff line change
`@@ -250,7 +250,7 @@ public final static long bigIntegerToUnsignedLong(BigInteger value) {`
`250`	`250`	`* @return aligned value`
`251`	`251`	`*/`
`252`	`252`	`public static long getUnsignedAlignedValue(long unsignedValue, long alignment) {`
`253`		`- if (unsignedValue % alignment == 0) {`
	`253`	`+ if (alignment == 0 \|\| unsignedValue % alignment == 0) {`
`254`	`254`	`return unsignedValue;`
`255`	`255`	`}`
`256`	`256`	`boolean negative = unsignedValue < 0;`