Skip to content

Commit ea6f9fb

Browse files
sbattensbatten
authored
remove panel location options in favor of new side panel behavior (microsoft#140742)
* remove panel location * better command names * smaller alignment window
1 parent 17997da commit ea6f9fb

File tree

16 files changed

+187
-315
lines changed

16 files changed

+187
-315
lines changed

‎src/vs/platform/actions/common/actions.ts

+1-2
Original file line numberDiff line numberDiff line change
@@ -102,8 +102,6 @@ export class MenuId {
102102
static readonly ExtensionContext = new MenuId('ExtensionContext');
103103
static readonly GlobalActivity = new MenuId('GlobalActivity');
104104
static readonly LayoutControlMenu = new MenuId('LayoutControlMenu');
105-
static readonly LayoutControlPanelPositionMenu = new MenuId('LayoutControlPanelPositionMenu');
106-
static readonly LayoutControlPanelAlignmentMenu = new MenuId('LayoutControlPanelAlignmentMenu');
107105
static readonly MenubarMainMenu = new MenuId('MenubarMainMenu');
108106
static readonly MenubarAppearanceMenu = new MenuId('MenubarAppearanceMenu');
109107
static readonly MenubarDebugMenu = new MenuId('MenubarDebugMenu');
@@ -114,6 +112,7 @@ export class MenuId {
114112
static readonly MenubarHelpMenu = new MenuId('MenubarHelpMenu');
115113
static readonly MenubarLayoutMenu = new MenuId('MenubarLayoutMenu');
116114
static readonly MenubarNewBreakpointMenu = new MenuId('MenubarNewBreakpointMenu');
115+
static readonly MenubarPanelAlignmentMenu = new MenuId('MenubarPanelAlignmentMenu');
117116
static readonly MenubarPreferencesMenu = new MenuId('MenubarPreferencesMenu');
118117
static readonly MenubarRecentMenu = new MenuId('MenubarRecentMenu');
119118
static readonly MenubarSelectionMenu = new MenuId('MenubarSelectionMenu');

‎src/vs/workbench/browser/actions/layoutActions.ts

-37
Original file line numberDiff line numberDiff line change
@@ -781,43 +781,6 @@ registerAction2(class extends Action2 {
781781
}
782782
});
783783

784-
// --- Swap Panel View Locations
785-
786-
registerAction2(class extends Action2 {
787-
788-
constructor() {
789-
super({
790-
id: 'workbench.action.movePanelToSidePanel',
791-
title: {
792-
value: localize('movePanelToSidePanel', "Move Panel To Side Panel"),
793-
original: 'Move Panel To Side Panel'
794-
},
795-
category: CATEGORIES.View,
796-
f1: true,
797-
precondition: ContextKeyExpr.equals('config.workbench.experimental.sidePanel.enabled', true)
798-
});
799-
}
800-
run(accessor: ServicesAccessor, ...args: any[]): void {
801-
const viewDescriptorService = accessor.get(IViewDescriptorService);
802-
const layoutService = accessor.get(IWorkbenchLayoutService);
803-
804-
const panelContainers = viewDescriptorService.getViewContainersByLocation(ViewContainerLocation.Panel);
805-
const auxiliaryBarContainers = viewDescriptorService.getViewContainersByLocation(ViewContainerLocation.AuxiliaryBar);
806-
807-
panelContainers.forEach(viewContainer => viewDescriptorService.moveViewContainerToLocation(viewContainer, ViewContainerLocation.AuxiliaryBar));
808-
auxiliaryBarContainers.forEach(viewContainer => viewDescriptorService.moveViewContainerToLocation(viewContainer, ViewContainerLocation.Panel));
809-
810-
if (panelContainers.length) {
811-
layoutService.setPartHidden(false, Parts.AUXILIARYBAR_PART);
812-
}
813-
814-
if (auxiliaryBarContainers.length) {
815-
layoutService.setPartHidden(false, Parts.PANEL_PART);
816-
}
817-
}
818-
819-
});
820-
821784
// --- Resize View
822785

823786
abstract class BaseResizeViewAction extends Action2 {

‎src/vs/workbench/browser/contextkeys.ts

+2-6
Original file line numberDiff line numberDiff line change
@@ -16,8 +16,8 @@ import { IWorkbenchEnvironmentService } from 'vs/workbench/services/environment/
1616
import { IEditorService } from 'vs/workbench/services/editor/common/editorService';
1717
import { WorkbenchState, IWorkspaceContextService } from 'vs/platform/workspace/common/workspace';
1818
import { SideBarVisibleContext } from 'vs/workbench/common/viewlet';
19-
import { IWorkbenchLayoutService, Parts, positionToString } from 'vs/workbench/services/layout/browser/layoutService';
20-
import { PanelMaximizedContext, PanelPositionContext, PanelVisibleContext } from 'vs/workbench/common/panel';
19+
import { IWorkbenchLayoutService, Parts } from 'vs/workbench/services/layout/browser/layoutService';
20+
import { PanelMaximizedContext, PanelVisibleContext } from 'vs/workbench/common/panel';
2121
import { getRemoteName, getVirtualWorkspaceScheme } from 'vs/platform/remote/common/remoteHosts';
2222
import { IWorkingCopyService } from 'vs/workbench/services/workingCopy/common/workingCopyService';
2323
import { isNative } from 'vs/base/common/platform';
@@ -82,7 +82,6 @@ export class WorkbenchContextKeysHandler extends Disposable {
8282
private isCenteredLayoutContext: IContextKey<boolean>;
8383
private sideBarVisibleContext: IContextKey<boolean>;
8484
private editorAreaVisibleContext: IContextKey<boolean>;
85-
private panelPositionContext: IContextKey<string>;
8685
private panelVisibleContext: IContextKey<boolean>;
8786
private panelMaximizedContext: IContextKey<boolean>;
8887
private auxiliaryBarVisibleContext: IContextKey<boolean>;
@@ -198,8 +197,6 @@ export class WorkbenchContextKeysHandler extends Disposable {
198197
this.sideBarVisibleContext = SideBarVisibleContext.bindTo(this.contextKeyService);
199198

200199
// Panel
201-
this.panelPositionContext = PanelPositionContext.bindTo(this.contextKeyService);
202-
this.panelPositionContext.set(positionToString(this.layoutService.getPanelPosition()));
203200
this.panelVisibleContext = PanelVisibleContext.bindTo(this.contextKeyService);
204201
this.panelVisibleContext.set(this.layoutService.isVisible(Parts.PANEL_PART));
205202
this.panelMaximizedContext = PanelMaximizedContext.bindTo(this.contextKeyService);
@@ -247,7 +244,6 @@ export class WorkbenchContextKeysHandler extends Disposable {
247244
this._register(this.layoutService.onDidChangeZenMode(enabled => this.inZenModeContext.set(enabled)));
248245
this._register(this.layoutService.onDidChangeFullscreen(fullscreen => this.isFullscreenContext.set(fullscreen)));
249246
this._register(this.layoutService.onDidChangeCenteredLayout(centered => this.isCenteredLayoutContext.set(centered)));
250-
this._register(this.layoutService.onDidChangePanelPosition(position => this.panelPositionContext.set(position)));
251247

252248
this._register(this.paneCompositeService.onDidPaneCompositeClose(() => this.updateSideBarContextKeys()));
253249
this._register(this.paneCompositeService.onDidPaneCompositeOpen(() => this.updateSideBarContextKeys()));

‎src/vs/workbench/browser/layout.ts

+36-135
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import { IUntypedEditorInput, pathsToEditors } from 'vs/workbench/common/editor'
1313
import { SideBySideEditorInput } from 'vs/workbench/common/editor/sideBySideEditorInput';
1414
import { SidebarPart } from 'vs/workbench/browser/parts/sidebar/sidebarPart';
1515
import { PanelPart } from 'vs/workbench/browser/parts/panel/panelPart';
16-
import { Position, Parts, PanelOpensMaximizedOptions, IWorkbenchLayoutService, positionFromString, positionToString, panelOpensMaximizedFromString, PanelAlignment } from 'vs/workbench/services/layout/browser/layoutService';
16+
import { Position, Parts, PanelOpensMaximizedOptions, IWorkbenchLayoutService, positionToString, panelOpensMaximizedFromString, PanelAlignment } from 'vs/workbench/services/layout/browser/layoutService';
1717
import { IWorkspaceContextService, WorkbenchState } from 'vs/platform/workspace/common/workspace';
1818
import { IStorageService, StorageScope, WillSaveStateReason } from 'vs/platform/storage/common/storage';
1919
import { IConfigurationService } from 'vs/platform/configuration/common/configuration';
@@ -116,9 +116,6 @@ export abstract class Layout extends Disposable implements IWorkbenchLayoutServi
116116
private readonly _onDidChangeWindowMaximized = this._register(new Emitter<boolean>());
117117
readonly onDidChangeWindowMaximized = this._onDidChangeWindowMaximized.event;
118118

119-
private readonly _onDidChangePanelPosition = this._register(new Emitter<string>());
120-
readonly onDidChangePanelPosition = this._onDidChangePanelPosition.event;
121-
122119
private readonly _onDidChangePartVisibility = this._register(new Emitter<void>());
123120
readonly onDidChangePartVisibility = this._onDidChangePartVisibility.event;
124121

@@ -428,10 +425,6 @@ export abstract class Layout extends Disposable implements IWorkbenchLayoutServi
428425
this.setSideBarPosition(change.value as Position);
429426
}
430427

431-
if (change.key === LayoutStateKeys.PANEL_POSITION) {
432-
this.setPanelPosition(change.value as Position);
433-
}
434-
435428
if (change.key === LayoutStateKeys.PANEL_ALIGNMENT) {
436429
this.setPanelAlignment(change.value as PanelAlignment);
437430
}
@@ -990,18 +983,15 @@ export abstract class Layout extends Disposable implements IWorkbenchLayoutServi
990983
}
991984

992985
getMaximumEditorDimensions(): Dimension {
993-
const panelPosition = this.getPanelPosition();
994-
const isColumn = panelPosition === Position.RIGHT || panelPosition === Position.LEFT;
995986
const takenWidth =
996987
(this.isVisible(Parts.ACTIVITYBAR_PART) ? this.activityBarPartView.minimumWidth : 0) +
997988
(this.isVisible(Parts.SIDEBAR_PART) ? this.sideBarPartView.minimumWidth : 0) +
998-
(this.isVisible(Parts.PANEL_PART) && isColumn ? this.panelPartView.minimumWidth : 0) +
999989
(this.isVisible(Parts.AUXILIARYBAR_PART) ? this.auxiliaryBarPartView.minimumWidth : 0);
1000990

1001991
const takenHeight =
1002992
(this.isVisible(Parts.TITLEBAR_PART) ? this.titleBarPartView.minimumHeight : 0) +
1003993
(this.isVisible(Parts.STATUSBAR_PART) ? this.statusBarPartView.minimumHeight : 0) +
1004-
(this.isVisible(Parts.PANEL_PART) && !isColumn ? this.panelPartView.minimumHeight : 0);
994+
(this.isVisible(Parts.PANEL_PART) ? this.panelPartView.minimumHeight : 0);
1005995

1006996
const availableWidth = this.dimension.width - takenWidth;
1007997
const availableHeight = this.dimension.height - takenHeight;
@@ -1224,7 +1214,7 @@ export abstract class Layout extends Disposable implements IWorkbenchLayoutServi
12241214
// Panel Size
12251215
const panelSize = this.stateModel.getRuntimeValue(LayoutStateKeys.PANEL_HIDDEN)
12261216
? this.workbenchGrid.getViewCachedVisibleSize(this.panelPartView)
1227-
: (this.stateModel.getRuntimeValue(LayoutStateKeys.PANEL_POSITION) === Position.BOTTOM ? this.workbenchGrid.getViewSize(this.panelPartView).height : this.workbenchGrid.getViewSize(this.panelPartView).width);
1217+
: this.workbenchGrid.getViewSize(this.panelPartView).height;
12281218
this.stateModel.setInitializationValue(LayoutStateKeys.PANEL_SIZE, panelSize as number);
12291219

12301220
// Auxiliary Bar Size
@@ -1317,8 +1307,8 @@ export abstract class Layout extends Disposable implements IWorkbenchLayoutServi
13171307

13181308
this.workbenchGrid.resizeView(this.panelPartView,
13191309
{
1320-
width: viewSize.width + (this.getPanelPosition() !== Position.BOTTOM ? sizeChangePxWidth : 0),
1321-
height: viewSize.height + (this.getPanelPosition() !== Position.BOTTOM ? 0 : sizeChangePxHeight)
1310+
width: viewSize.width,
1311+
height: viewSize.height + sizeChangePxHeight
13221312
});
13231313

13241314
break;
@@ -1500,11 +1490,6 @@ export abstract class Layout extends Disposable implements IWorkbenchLayoutServi
15001490
}
15011491

15021492
setPanelAlignment(alignment: PanelAlignment, skipLayout?: boolean): void {
1503-
// Panel alignment only applies to a panel in the bottom position
1504-
if (this.getPanelPosition() !== Position.BOTTOM) {
1505-
return;
1506-
}
1507-
15081493
this.stateModel.setRuntimeValue(LayoutStateKeys.PANEL_ALIGNMENT, alignment);
15091494

15101495
this.adjustPartPositions(this.getSideBarPosition(), alignment);
@@ -1586,23 +1571,18 @@ export abstract class Layout extends Disposable implements IWorkbenchLayoutServi
15861571

15871572
toggleMaximizedPanel(): void {
15881573
const size = this.workbenchGrid.getViewSize(this.panelPartView);
1589-
const panelPosition = this.getPanelPosition();
15901574
const isMaximized = this.isPanelMaximized();
15911575
if (!isMaximized) {
15921576
if (this.isVisible(Parts.PANEL_PART)) {
1593-
if (panelPosition === Position.BOTTOM) {
1594-
this.stateModel.setRuntimeValue(LayoutStateKeys.PANEL_LAST_NON_MAXIMIZED_HEIGHT, size.height);
1595-
} else {
1596-
this.stateModel.setRuntimeValue(LayoutStateKeys.PANEL_LAST_NON_MAXIMIZED_WIDTH, size.width);
1597-
}
1577+
this.stateModel.setRuntimeValue(LayoutStateKeys.PANEL_LAST_NON_MAXIMIZED_HEIGHT, size.height);
15981578
}
15991579

16001580
this.setEditorHidden(true);
16011581
} else {
16021582
this.setEditorHidden(false);
16031583
this.workbenchGrid.resizeView(this.panelPartView, {
1604-
width: panelPosition === Position.BOTTOM ? size.width : this.stateModel.getRuntimeValue(LayoutStateKeys.PANEL_LAST_NON_MAXIMIZED_WIDTH),
1605-
height: panelPosition === Position.BOTTOM ? this.stateModel.getRuntimeValue(LayoutStateKeys.PANEL_LAST_NON_MAXIMIZED_HEIGHT) : size.height
1584+
width: size.width,
1585+
height: this.stateModel.getRuntimeValue(LayoutStateKeys.PANEL_LAST_NON_MAXIMIZED_HEIGHT)
16061586
});
16071587
}
16081588
this.stateModel.setRuntimeValue(LayoutStateKeys.PANEL_WAS_LAST_MAXIMIZED, !isMaximized);
@@ -1727,62 +1707,6 @@ export abstract class Layout extends Disposable implements IWorkbenchLayoutServi
17271707
this.configurationService.updateValue('window.menuBarVisibility', newVisibilityValue);
17281708
}
17291709

1730-
getPanelPosition(): Position {
1731-
return this.stateModel.getRuntimeValue(LayoutStateKeys.PANEL_POSITION);
1732-
}
1733-
1734-
setPanelPosition(position: Position): void {
1735-
if (!this.isVisible(Parts.PANEL_PART)) {
1736-
this.setPanelHidden(false);
1737-
}
1738-
1739-
const panelPart = this.getPart(Parts.PANEL_PART);
1740-
const oldPositionValue = positionToString(this.getPanelPosition());
1741-
const newPositionValue = positionToString(position);
1742-
1743-
this.stateModel.setRuntimeValue(LayoutStateKeys.PANEL_POSITION, position);
1744-
1745-
// Adjust CSS
1746-
const panelContainer = assertIsDefined(panelPart.getContainer());
1747-
panelContainer.classList.remove(oldPositionValue);
1748-
panelContainer.classList.add(newPositionValue);
1749-
1750-
// Update Styles
1751-
panelPart.updateStyles();
1752-
1753-
// Layout
1754-
const size = this.workbenchGrid.getViewSize(this.panelPartView);
1755-
const sideBarSize = this.workbenchGrid.getViewSize(this.sideBarPartView);
1756-
1757-
const editorHidden = !this.isVisible(Parts.EDITOR_PART);
1758-
1759-
// Save last non-maximized size for panel before move
1760-
if (newPositionValue !== oldPositionValue && !editorHidden) {
1761-
1762-
// Save the current size of the panel for the new orthogonal direction
1763-
// If moving down, save the width of the panel
1764-
// Otherwise, save the height of the panel
1765-
if (position === Position.BOTTOM) {
1766-
this.stateModel.setRuntimeValue(LayoutStateKeys.PANEL_LAST_NON_MAXIMIZED_WIDTH, size.width);
1767-
} else if (positionFromString(oldPositionValue) === Position.BOTTOM) {
1768-
this.stateModel.setRuntimeValue(LayoutStateKeys.PANEL_LAST_NON_MAXIMIZED_HEIGHT, size.height);
1769-
}
1770-
}
1771-
1772-
if (position === Position.BOTTOM) {
1773-
this.workbenchGrid.moveView(this.panelPartView, editorHidden ? size.height : this.stateModel.getRuntimeValue(LayoutStateKeys.PANEL_LAST_NON_MAXIMIZED_HEIGHT), this.editorPartView, Direction.Down);
1774-
} else if (position === Position.RIGHT) {
1775-
this.workbenchGrid.moveView(this.panelPartView, editorHidden ? size.width : this.stateModel.getRuntimeValue(LayoutStateKeys.PANEL_LAST_NON_MAXIMIZED_WIDTH), this.editorPartView, Direction.Right);
1776-
} else {
1777-
this.workbenchGrid.moveView(this.panelPartView, editorHidden ? size.width : this.stateModel.getRuntimeValue(LayoutStateKeys.PANEL_LAST_NON_MAXIMIZED_WIDTH), this.editorPartView, Direction.Left);
1778-
}
1779-
1780-
// Reset sidebar to original size before shifting the panel
1781-
this.workbenchGrid.resizeView(this.sideBarPartView, sideBarSize);
1782-
1783-
this._onDidChangePanelPosition.fire(newPositionValue);
1784-
}
1785-
17861710
isWindowMaximized() {
17871711
return this.windowState.runtime.maximized;
17881712
}
@@ -1868,64 +1792,44 @@ export abstract class Layout extends Disposable implements IWorkbenchLayoutServi
18681792
const panelSize = this.stateModel.getInitializationValue(LayoutStateKeys.PANEL_SIZE) ? 0 : nodes.panel.size;
18691793

18701794
const result = [] as ISerializedNode[];
1871-
if (this.stateModel.getRuntimeValue(LayoutStateKeys.PANEL_POSITION) !== Position.BOTTOM) {
1872-
result.push(nodes.editor);
1873-
nodes.editor.size = availableWidth - activityBarSize - sideBarSize - panelSize - auxiliaryBarSize;
1874-
if (this.stateModel.getRuntimeValue(LayoutStateKeys.PANEL_POSITION) === Position.RIGHT) {
1875-
result.push(nodes.panel);
1876-
} else {
1877-
result.splice(0, 0, nodes.panel);
1878-
}
1795+
const panelAlignment = this.stateModel.getRuntimeValue(LayoutStateKeys.PANEL_ALIGNMENT);
1796+
const sideBarPosition = this.stateModel.getRuntimeValue(LayoutStateKeys.SIDEBAR_POSITON);
1797+
const sideBarNextToEditor = !(panelAlignment === 'center' || (sideBarPosition === Position.LEFT && panelAlignment === 'right') || (sideBarPosition === Position.RIGHT && panelAlignment === 'left'));
1798+
const auxiliaryBarNextToEditor = !(panelAlignment === 'center' || (sideBarPosition === Position.RIGHT && panelAlignment === 'right') || (sideBarPosition === Position.LEFT && panelAlignment === 'left'));
18791799

1880-
if (this.stateModel.getRuntimeValue(LayoutStateKeys.SIDEBAR_POSITON) === Position.LEFT) {
1881-
result.push(nodes.auxiliaryBar);
1800+
const editorSectionWidth = availableWidth - activityBarSize - (sideBarNextToEditor ? 0 : sideBarSize) - (auxiliaryBarNextToEditor ? 0 : auxiliaryBarSize);
1801+
result.push({
1802+
type: 'branch',
1803+
data: [this.arrangeEditorNodes({
1804+
editor: nodes.editor,
1805+
sideBar: sideBarNextToEditor ? nodes.sideBar : undefined,
1806+
auxiliaryBar: auxiliaryBarNextToEditor ? nodes.auxiliaryBar : undefined
1807+
}, availableHeight - panelSize, editorSectionWidth), nodes.panel],
1808+
size: editorSectionWidth
1809+
});
1810+
1811+
if (!sideBarNextToEditor) {
1812+
if (sideBarPosition === Position.LEFT) {
18821813
result.splice(0, 0, nodes.sideBar);
1883-
result.splice(0, 0, nodes.activityBar);
18841814
} else {
1885-
result.splice(0, 0, nodes.auxiliaryBar);
18861815
result.push(nodes.sideBar);
1887-
result.push(nodes.activityBar);
1888-
}
1889-
} else {
1890-
const panelAlignment = this.stateModel.getRuntimeValue(LayoutStateKeys.PANEL_ALIGNMENT);
1891-
const sideBarPosition = this.stateModel.getRuntimeValue(LayoutStateKeys.SIDEBAR_POSITON);
1892-
const sideBarNextToEditor = !(panelAlignment === 'center' || (sideBarPosition === Position.LEFT && panelAlignment === 'right') || (sideBarPosition === Position.RIGHT && panelAlignment === 'left'));
1893-
const auxiliaryBarNextToEditor = !(panelAlignment === 'center' || (sideBarPosition === Position.RIGHT && panelAlignment === 'right') || (sideBarPosition === Position.LEFT && panelAlignment === 'left'));
1894-
1895-
const editorSectionWidth = availableWidth - activityBarSize - (sideBarNextToEditor ? 0 : sideBarSize) - (auxiliaryBarNextToEditor ? 0 : auxiliaryBarSize);
1896-
result.push({
1897-
type: 'branch',
1898-
data: [this.arrangeEditorNodes({
1899-
editor: nodes.editor,
1900-
sideBar: sideBarNextToEditor ? nodes.sideBar : undefined,
1901-
auxiliaryBar: auxiliaryBarNextToEditor ? nodes.auxiliaryBar : undefined
1902-
}, availableHeight - panelSize, editorSectionWidth), nodes.panel],
1903-
size: editorSectionWidth
1904-
});
1905-
1906-
if (!sideBarNextToEditor) {
1907-
if (sideBarPosition === Position.LEFT) {
1908-
result.splice(0, 0, nodes.sideBar);
1909-
} else {
1910-
result.push(nodes.sideBar);
1911-
}
1912-
}
1913-
1914-
if (!auxiliaryBarNextToEditor) {
1915-
if (sideBarPosition === Position.RIGHT) {
1916-
result.splice(0, 0, nodes.auxiliaryBar);
1917-
} else {
1918-
result.push(nodes.auxiliaryBar);
1919-
}
19201816
}
1817+
}
19211818

1922-
if (sideBarPosition === Position.LEFT) {
1923-
result.splice(0, 0, nodes.activityBar);
1819+
if (!auxiliaryBarNextToEditor) {
1820+
if (sideBarPosition === Position.RIGHT) {
1821+
result.splice(0, 0, nodes.auxiliaryBar);
19241822
} else {
1925-
result.push(nodes.activityBar);
1823+
result.push(nodes.auxiliaryBar);
19261824
}
19271825
}
19281826

1827+
if (sideBarPosition === Position.LEFT) {
1828+
result.splice(0, 0, nodes.activityBar);
1829+
} else {
1830+
result.push(nodes.activityBar);
1831+
}
1832+
19291833
return result;
19301834
}
19311835

@@ -2027,7 +1931,6 @@ export abstract class Layout extends Disposable implements IWorkbenchLayoutServi
20271931
panelVisible: boolean;
20281932
statusbarVisible: boolean;
20291933
sideBarPosition: string;
2030-
panelPosition: string;
20311934
};
20321935

20331936
type StartupLayoutEventClassification = {
@@ -2037,7 +1940,6 @@ export abstract class Layout extends Disposable implements IWorkbenchLayoutServi
20371940
panelVisible: { classification: 'SystemMetaData', purpose: 'FeatureInsight', isMeasurement: true };
20381941
statusbarVisible: { classification: 'SystemMetaData', purpose: 'FeatureInsight', isMeasurement: true };
20391942
sideBarPosition: { classification: 'SystemMetaData', purpose: 'FeatureInsight'; };
2040-
panelPosition: { classification: 'SystemMetaData', purpose: 'FeatureInsight'; };
20411943
};
20421944

20431945
const layoutDescriptor: StartupLayoutEvent = {
@@ -2047,7 +1949,6 @@ export abstract class Layout extends Disposable implements IWorkbenchLayoutServi
20471949
panelVisible: !this.stateModel.getRuntimeValue(LayoutStateKeys.PANEL_HIDDEN),
20481950
statusbarVisible: !this.stateModel.getRuntimeValue(LayoutStateKeys.STATUSBAR_HIDDEN),
20491951
sideBarPosition: positionToString(this.stateModel.getRuntimeValue(LayoutStateKeys.SIDEBAR_POSITON)),
2050-
panelPosition: positionToString(this.stateModel.getRuntimeValue(LayoutStateKeys.PANEL_POSITION)),
20511952
};
20521953

20531954
this.telemetryService.publicLog2<StartupLayoutEvent, StartupLayoutEventClassification>('startupLayout', layoutDescriptor);

0 commit comments

Comments
 (0)