Merge pull request microsoft#141926 from microsoft/sandy081/fix141910

sandy081 · web-flow · commit ce199e66c849 · 2022-02-01T10:30:51.000+01:00
Fix getting older versions for platform specific extensions
diff --git a/src/vs/platform/extensionManagement/common/extensionGalleryService.ts b/src/vs/platform/extensionManagement/common/extensionGalleryService.ts
@@ -1052,9 +1052,9 @@ abstract class AbstractExtensionGalleryService implements IExtensionGalleryServi
 				if (seenVersions.has(version.version)) {
 					return;
 				}
-				seenVersions.add(version.version);
 				if (await this.isValidVersion(version, preRelease ? 'prerelease' : 'release', true, allTargetPlatforms, targetPlatform)) {
 					result.push({ version: version.version, date: version.lastUpdated, isPreReleaseVersion: isPreReleaseVersion(version) });
+					seenVersions.add(version.version);
 				}
 			} catch (error) { /* Ignore error and skip version */ }
 		}));

Original file line number	Diff line number	Diff line change
`@@ -1052,9 +1052,9 @@ abstract class AbstractExtensionGalleryService implements IExtensionGalleryServi`
`1052`	`1052`	`if (seenVersions.has(version.version)) {`
`1053`	`1053`	`return;`
`1054`	`1054`	`}`
`1055`		`- seenVersions.add(version.version);`
`1056`	`1055`	`if (await this.isValidVersion(version, preRelease ? 'prerelease' : 'release', true, allTargetPlatforms, targetPlatform)) {`
`1057`	`1056`	`result.push({ version: version.version, date: version.lastUpdated, isPreReleaseVersion: isPreReleaseVersion(version) });`
	`1057`	`+ seenVersions.add(version.version);`
`1058`	`1058`	`}`
`1059`	`1059`	`} catch (error) { /* Ignore error and skip version */ }`
`1060`	`1060`	`}));`