Merge pull request microsoft#141650 from microsoft/tyriar/141615

Ensure quick pick is closed on view output

Author: Tyriar

src/vs/workbench/contrib/terminal/browser/terminalInstance.ts

@@ -784,9 +784,11 @@ export class TerminalInstance extends Disposable implements ITerminalInstance {
 			}
 		}
 		const outputProvider = this._instantiationService.createInstance(TerminalOutputProvider);
-		const result = await this._quickInputService.pick(items.reverse(), {
-			onDidTriggerItemButton: (async e => {
-				const selectedCommand = e.item.command;
+		const quickPick = this._quickInputService.createQuickPick();
+		quickPick.items = items.reverse();
+		return new Promise<void>(r => {
+			quickPick.onDidTriggerItemButton(async e => {
+				const selectedCommand = (e.item as Item).command;
 				const output = selectedCommand?.getOutput();
 				if (output && selectedCommand?.command) {
 					const textContent = await outputProvider.provideTextContent(URI.from(
@@ -797,16 +799,21 @@ export class TerminalInstance extends Disposable implements ITerminalInstance {
 							query: `terminal-output-${selectedCommand.timestamp}-${this.instanceId}`
 						}));
 					if (textContent) {
-						this._editorService.openEditor({
+						await this._editorService.openEditor({
 							resource: textContent.uri
 						});
 					}
 				}
-			})
+				quickPick.hide();
+			});
+			quickPick.onDidAccept(e => {
+				const result = quickPick.activeItems[0];
+				this.sendText(type === 'cwd' ? `cd ${result.label}` : result.label, true);
+				quickPick.hide();
+			});
+			quickPick.show();
+			quickPick.onDidHide(() => r());
 		});
-		if (result) {
-			this.sendText(type === 'cwd' ? `cd ${result.label}` : result.label, true);
-		}
 	}
 
 	detachFromElement(): void {