Merge branch 'main' into sandy081/extensionResourceHandler

Author: sandy081

.vscode/settings.json

@@ -84,12 +84,6 @@
 		"editor.formatOnSave": true
 	},
 	"typescript.tsc.autoDetect": "off",
-	"editor.inlayHints.enabled": true,
-	"typescript.inlayHints.enumMemberValues.enabled": true,
-	"typescript.inlayHints.functionLikeReturnTypes.enabled": true,
-	"typescript.inlayHints.parameterTypes.enabled": true,
-	"typescript.inlayHints.propertyDeclarationTypes.enabled": true,
-	"typescript.inlayHints.variableTypes.enabled": true,
 	"testing.autoRun.mode": "rerun",
 	"conventionalCommits.scopes": [
 		"tree",

build/lib/eslint/code-no-unused-expressions.js

@@ -108,13 +108,16 @@ module.exports = {
             if (allowTaggedTemplates && node.type === 'TaggedTemplateExpression') {
                 return true;
             }
-            return /^(?:Assignment|OptionalCall|Call|New|Update|Yield|Await)Expression$/u.test(node.type) ||
+            if (node.type === 'ExpressionStatement') {
+                return isValidExpression(node.expression);
+            }
+            return /^(?:Assignment|OptionalCall|Call|New|Update|Yield|Await|Chain)Expression$/u.test(node.type) ||
                 (node.type === 'UnaryExpression' && ['delete', 'void'].indexOf(node.operator) >= 0);
         }
         return {
             ExpressionStatement(node) {
                 if (!isValidExpression(node.expression) && !isDirective(node, context.getAncestors())) {
-                    context.report({ node: node, message: 'Expected an assignment or function call and instead saw an expression.' });
+                    context.report({ node: node, message: `Expected an assignment or function call and instead saw an expression. ${node.expression}` });
                 }
             }
         };

build/lib/eslint/code-no-unused-expressions.ts

@@ -133,14 +133,18 @@ module.exports = {
 				return true;
 			}
 
-			return /^(?:Assignment|OptionalCall|Call|New|Update|Yield|Await)Expression$/u.test(node.type) ||
+			if (node.type === 'ExpressionStatement') {
+				return isValidExpression(node.expression);
+			}
+
+			return /^(?:Assignment|OptionalCall|Call|New|Update|Yield|Await|Chain)Expression$/u.test(node.type) ||
 				(node.type === 'UnaryExpression' && ['delete', 'void'].indexOf(node.operator) >= 0);
 		}
 
 		return {
 			ExpressionStatement(node: TSESTree.ExpressionStatement) {
 				if (!isValidExpression(node.expression) && !isDirective(node, <TSESTree.Node[]>context.getAncestors())) {
-					context.report({ node: <ESTree.Node>node, message: 'Expected an assignment or function call and instead saw an expression.' });
+					context.report({ node: <ESTree.Node>node, message: `Expected an assignment or function call and instead saw an expression. ${node.expression}` });
 				}
 			}
 		};

build/package.json

@@ -42,7 +42,7 @@
     "@types/webpack": "^4.41.25",
     "@types/xml2js": "0.0.33",
     "@typescript-eslint/experimental-utils": "~2.13.0",
-    "@typescript-eslint/parser": "^3.3.0",
+    "@typescript-eslint/parser": "^5.10.0",
     "@vscode/iconv-lite-umd": "0.7.0",
     "applicationinsights": "1.4.2",
     "byline": "^5.0.0",