Revert "always set aria-selected, even for listbox"

This reverts commit 1356392.

Author: isidorn

src/vs/base/browser/ui/list/listWidget.ts

@@ -196,17 +196,19 @@ class Trait<T> implements ISpliceable<boolean>, IDisposable {
 
 class SelectionTrait<T> extends Trait<T> {
 
-	constructor() {
+	constructor(private setAriaSelected: boolean) {
 		super('selected');
 	}
 
 	override renderIndex(index: number, container: HTMLElement): void {
 		super.renderIndex(index, container);
 
-		if (this.contains(index)) {
-			container.setAttribute('aria-selected', 'true');
-		} else {
-			container.setAttribute('aria-selected', 'false');
+		if (this.setAriaSelected) {
+			if (this.contains(index)) {
+				container.setAttribute('aria-selected', 'true');
+			} else {
+				container.setAttribute('aria-selected', 'false');
+			}
 		}
 	}
 }
@@ -1315,7 +1317,7 @@ export class List<T> implements ISpliceable<T>, IThemable, IDisposable {
 		private _options: IListOptions<T> = DefaultOptions
 	) {
 		const role = this._options.accessibilityProvider && this._options.accessibilityProvider.getWidgetRole ? this._options.accessibilityProvider?.getWidgetRole() : 'list';
-		this.selection = new SelectionTrait();
+		this.selection = new SelectionTrait(role !== 'listbox');
 
 		mixin(_options, defaultStyles, false);