Skip to content

URL should not be required on login when it is predefined on global storage #182

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
liorb-canva opened this issue Dec 17, 2023 · 3 comments · Fixed by #200
Closed

URL should not be required on login when it is predefined on global storage #182

liorb-canva opened this issue Dec 17, 2023 · 3 comments · Fixed by #200
Assignees

Comments

@liorb-canva
Copy link

liorb-canva commented Dec 17, 2023

Context:
For self hosteed coder server, a private url needed to be provided in login screen
This url is not alweys intuative and easy to remember

Accepted behaviour
If the URL is defined in global config or in the CODER_URL environment variable, do not show the user a prompt to fill the url, and redirect to the pre-defined url to login.

Current Behaviour
The login function, ignored the url stored in Storage class
Screenshot 2023-12-18 at 10 15 38 am

@matifali
Copy link
Member

matifali commented Dec 18, 2023

While doing this, make sure it can also handle multiple coder deployments gracefully.
Related: #173

@code-asher
Copy link
Member

I think we might still want to show the login prompt but just prefill it, otherwise what if you want to connect to a different deployment but it keeps auto-logging you into a different one?

@matifali
Copy link
Member

The best would be to add the ability to list recently used URLs and prefilled the last connected one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants