Skip to content
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.

Commit bf5eec5

Browse files
committedJun 5, 2024
Do not clear cli config on logout
If we do this, users will just be forced to provide credentials all over again when they reconnect to a workspace from this deployment, say from the recents menu or from just reopening VS Code. Since the only way to have multiple deployments right now is to log out of one then log into the other, it seems like this will just cause more needless work. Possibly we should instead allow logging in if already logged in (maybe call it "switch deployment") to support adding a new deployment without logging out first, and then show a warning while logging out, but for now do this. This matches the JetBrains plugin behavior, at least. Can revisit when adding support for listing multiple deployments at a time.
1 parent d3c42ee commit bf5eec5

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed
 

‎src/commands.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -215,9 +215,6 @@ export class Commands {
215215
await this.storage.setUrl(undefined)
216216
await this.storage.setSessionToken(undefined)
217217

218-
// Clear from disk.
219-
await this.storage.configureCli(toSafeHost(url), undefined, undefined)
220-
221218
await vscode.commands.executeCommand("setContext", "coder.authenticated", false)
222219
vscode.window.showInformationMessage("You've been logged out of Coder!", "Login").then((action) => {
223220
if (action === "Login") {

0 commit comments

Comments
 (0)
Please sign in to comment.