Skip to content

Commit e0c670d

Browse files
committed
default remote repo build mode = true
1 parent a31950f commit e0c670d

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

internal/provider/cached_image_resource.go

+4-2
Original file line numberDiff line numberDiff line change
@@ -342,7 +342,8 @@ func (r *CachedImageResource) Read(ctx context.Context, req resource.ReadRequest
342342
data.Env = appendKnownEnvToList(data.Env, "ENVBUILDER_GIT_PASSWORD", data.GitPassword)
343343
}
344344
if !data.RemoteRepoBuildMode.IsNull() {
345-
data.Env = appendKnownEnvToList(data.Env, "ENVBUILDER_REMOTE_REPO_BUILD_MODE", data.RemoteRepoBuildMode)
345+
// Default to remote build mode.
346+
data.Env = appendKnownEnvToList(data.Env, "ENVBUILDER_REMOTE_REPO_BUILD_MODE", types.BoolValue(true))
346347
}
347348

348349
resp.Diagnostics.Append(resp.State.Set(ctx, &data)...)
@@ -394,7 +395,8 @@ func (r *CachedImageResource) Create(ctx context.Context, req resource.CreateReq
394395
data.Env = appendKnownEnvToList(data.Env, "ENVBUILDER_GIT_PASSWORD", data.GitPassword)
395396
}
396397
if !data.RemoteRepoBuildMode.IsNull() {
397-
data.Env = appendKnownEnvToList(data.Env, "ENVBUILDER_REMOTE_REPO_BUILD_MODE", data.RemoteRepoBuildMode)
398+
// Default to remote build mode.
399+
data.Env = appendKnownEnvToList(data.Env, "ENVBUILDER_REMOTE_REPO_BUILD_MODE", types.BoolValue(true))
398400
}
399401

400402
// Save data into Terraform state

internal/provider/cached_image_resource_test.go

+3
Original file line numberDiff line numberDiff line change
@@ -41,6 +41,7 @@ func TestAccCachedImageDataSource(t *testing.T) {
4141
resource.TestCheckResourceAttr("envbuilder_cached_image.test", "id", uuid.Nil.String()),
4242
resource.TestCheckResourceAttr("envbuilder_cached_image.test", "exists", "false"),
4343
resource.TestCheckResourceAttrSet("envbuilder_cached_image.test", "env.0"),
44+
resource.TestCheckResourceAttr("envbuilder_cached_image.test", "remote_repo_build_mode", "true"),
4445
// Cached image should be set to the builder image.
4546
resource.TestCheckResourceAttr("envbuilder_cached_image.test", "image", deps.BuilderImage),
4647
// Inputs should still be present.
@@ -62,6 +63,7 @@ func TestAccCachedImageDataSource(t *testing.T) {
6263
resource.TestCheckResourceAttr("envbuilder_cached_image.test", "id", uuid.Nil.String()),
6364
resource.TestCheckResourceAttr("envbuilder_cached_image.test", "exists", "false"),
6465
resource.TestCheckResourceAttrSet("envbuilder_cached_image.test", "env.0"),
66+
resource.TestCheckResourceAttr("envbuilder_cached_image.test", "remote_repo_build_mode", "true"),
6567
// Cached image should be set to the builder image.
6668
resource.TestCheckResourceAttr("envbuilder_cached_image.test", "image", deps.BuilderImage),
6769
// Inputs should still be present.
@@ -86,6 +88,7 @@ func TestAccCachedImageDataSource(t *testing.T) {
8688
resource.TestCheckResourceAttr("envbuilder_cached_image.test", "cache_repo", deps.CacheRepo),
8789
resource.TestCheckResourceAttr("envbuilder_cached_image.test", "extra_env.FOO", "bar"),
8890
resource.TestCheckResourceAttr("envbuilder_cached_image.test", "git_url", deps.Repo.URL),
91+
resource.TestCheckResourceAttr("envbuilder_cached_image.test", "remote_repo_build_mode", "true"),
8992
// Should be empty
9093
resource.TestCheckNoResourceAttr("envbuilder_cached_image.test", "git_username"),
9194
resource.TestCheckNoResourceAttr("envbuilder_cached_image.test", "git_password"),

0 commit comments

Comments
 (0)