Skip to content

Commit 79b4947

Browse files
committed
default remote repo build mode = true
1 parent d928615 commit 79b4947

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

internal/provider/cached_image_resource.go

+4-2
Original file line numberDiff line numberDiff line change
@@ -339,7 +339,8 @@ func (r *CachedImageResource) Read(ctx context.Context, req resource.ReadRequest
339339
data.Env = appendKnownEnvToList(data.Env, "ENVBUILDER_GIT_PASSWORD", data.GitPassword)
340340
}
341341
if !data.RemoteRepoBuildMode.IsNull() {
342-
data.Env = appendKnownEnvToList(data.Env, "ENVBUILDER_REMOTE_REPO_BUILD_MODE", data.RemoteRepoBuildMode)
342+
// Default to remote build mode.
343+
data.Env = appendKnownEnvToList(data.Env, "ENVBUILDER_REMOTE_REPO_BUILD_MODE", types.BoolValue(true))
343344
}
344345

345346
resp.Diagnostics.Append(resp.State.Set(ctx, &data)...)
@@ -391,7 +392,8 @@ func (r *CachedImageResource) Create(ctx context.Context, req resource.CreateReq
391392
data.Env = appendKnownEnvToList(data.Env, "ENVBUILDER_GIT_PASSWORD", data.GitPassword)
392393
}
393394
if !data.RemoteRepoBuildMode.IsNull() {
394-
data.Env = appendKnownEnvToList(data.Env, "ENVBUILDER_REMOTE_REPO_BUILD_MODE", data.RemoteRepoBuildMode)
395+
// Default to remote build mode.
396+
data.Env = appendKnownEnvToList(data.Env, "ENVBUILDER_REMOTE_REPO_BUILD_MODE", types.BoolValue(true))
395397
}
396398

397399
// Save data into Terraform state

internal/provider/cached_image_resource_test.go

+3
Original file line numberDiff line numberDiff line change
@@ -38,6 +38,7 @@ func TestAccCachedImageDataSource(t *testing.T) {
3838
resource.TestCheckResourceAttr("envbuilder_cached_image.test", "id", uuid.Nil.String()),
3939
resource.TestCheckResourceAttr("envbuilder_cached_image.test", "exists", "false"),
4040
resource.TestCheckResourceAttrSet("envbuilder_cached_image.test", "env.0"),
41+
resource.TestCheckResourceAttr("envbuilder_cached_image.test", "remote_repo_build_mode", "true"),
4142
// Cached image should be set to the builder image.
4243
resource.TestCheckResourceAttr("envbuilder_cached_image.test", "image", deps.BuilderImage),
4344
// Inputs should still be present.
@@ -59,6 +60,7 @@ func TestAccCachedImageDataSource(t *testing.T) {
5960
resource.TestCheckResourceAttr("envbuilder_cached_image.test", "id", uuid.Nil.String()),
6061
resource.TestCheckResourceAttr("envbuilder_cached_image.test", "exists", "false"),
6162
resource.TestCheckResourceAttrSet("envbuilder_cached_image.test", "env.0"),
63+
resource.TestCheckResourceAttr("envbuilder_cached_image.test", "remote_repo_build_mode", "true"),
6264
// Cached image should be set to the builder image.
6365
resource.TestCheckResourceAttr("envbuilder_cached_image.test", "image", deps.BuilderImage),
6466
// Inputs should still be present.
@@ -83,6 +85,7 @@ func TestAccCachedImageDataSource(t *testing.T) {
8385
resource.TestCheckResourceAttr("envbuilder_cached_image.test", "cache_repo", deps.CacheRepo),
8486
resource.TestCheckResourceAttr("envbuilder_cached_image.test", "extra_env.FOO", "bar"),
8587
resource.TestCheckResourceAttr("envbuilder_cached_image.test", "git_url", deps.Repo.URL),
88+
resource.TestCheckResourceAttr("envbuilder_cached_image.test", "remote_repo_build_mode", "true"),
8689
// Should be empty
8790
resource.TestCheckNoResourceAttr("envbuilder_cached_image.test", "git_username"),
8891
resource.TestCheckNoResourceAttr("envbuilder_cached_image.test", "git_password"),

0 commit comments

Comments
 (0)