clean up other tests

Author: ethanndickson

internal/provider/user_data_source_test.go

@@ -39,6 +39,16 @@ func TestAccUserDataSource(t *testing.T) {
 		Name:     "Example User",
 	})
 	require.NoError(t, err)
+
+	checkFn := resource.ComposeAggregateTestCheckFunc(
+		resource.TestCheckResourceAttr("data.coderd_user.test", "username", "example"),
+		resource.TestCheckResourceAttr("data.coderd_user.test", "name", "Example User"),
+		resource.TestCheckResourceAttr("data.coderd_user.test", "email", "[email protected]"),
+		resource.TestCheckResourceAttr("data.coderd_user.test", "roles.#", "1"),
+		resource.TestCheckResourceAttr("data.coderd_user.test", "roles.0", "auditor"),
+		resource.TestCheckResourceAttr("data.coderd_user.test", "login_type", "password"),
+		resource.TestCheckResourceAttr("data.coderd_user.test", "suspended", "false"),
+	)
 	t.Run("UserByUsername", func(t *testing.T) {
 		cfg := testAccUserDataSourceConfig{
 			URL:      client.URL.String(),
@@ -51,15 +61,7 @@ func TestAccUserDataSource(t *testing.T) {
 			Steps: []resource.TestStep{
 				{
 					Config: cfg.String(t),
-					Check: resource.ComposeAggregateTestCheckFunc(
-						resource.TestCheckResourceAttr("data.coderd_user.test", "username", "example"),
-						resource.TestCheckResourceAttr("data.coderd_user.test", "name", "Example User"),
-						resource.TestCheckResourceAttr("data.coderd_user.test", "email", "[email protected]"),
-						resource.TestCheckResourceAttr("data.coderd_user.test", "roles.#", "1"),
-						resource.TestCheckResourceAttr("data.coderd_user.test", "roles.0", "auditor"),
-						resource.TestCheckResourceAttr("data.coderd_user.test", "login_type", "password"),
-						resource.TestCheckResourceAttr("data.coderd_user.test", "suspended", "false"),
-					),
+					Check:  checkFn,
 				},
 			},
 		})
@@ -78,15 +80,7 @@ func TestAccUserDataSource(t *testing.T) {
 			Steps: []resource.TestStep{
 				{
 					Config: cfg.String(t),
-					Check: resource.ComposeAggregateTestCheckFunc(
-						resource.TestCheckResourceAttr("data.coderd_user.test", "username", "example"),
-						resource.TestCheckResourceAttr("data.coderd_user.test", "name", "Example User"),
-						resource.TestCheckResourceAttr("data.coderd_user.test", "email", "[email protected]"),
-						resource.TestCheckResourceAttr("data.coderd_user.test", "roles.#", "1"),
-						resource.TestCheckResourceAttr("data.coderd_user.test", "roles.0", "auditor"),
-						resource.TestCheckResourceAttr("data.coderd_user.test", "login_type", "password"),
-						resource.TestCheckResourceAttr("data.coderd_user.test", "suspended", "false"),
-					),
+					Check:  checkFn,
 				},
 			},
 		})